Files
gitea-tea/internal/app/pull_review_lifecycle.go
T
bircni f02245449b feat!: rebuild tea on Cobra with explicit noun/verb commands (#1126)
- **switch tea to the Cobra command tree:** `internal/app` wires the packages from parts 1–4 into explicit noun/verb commands with `--repo`, `--json` / `--jq`, `--sudo` and `--debug`; `main.go` points at it. Build, release and docs tooling (`tools/cli-docs`, Makefile, goreleaser, snap, CI) and README / CONTRIBUTING are updated.
- **remove the urfave/cli command tree:** deletes `cmd/`, `modules/`, the old integration tests, contrib completion scripts and the generated `docs/CLI.md`, and drops their dependencies. This commit only deletes.

## Breaking changes

This is a breaking release. It requires Gitea 28 or newer; configuration moves to separate `config.yml` and `hosts.yml` files and requires fresh authentication, and command names, aliases, flags and output formats change. `docs/migration-1.0.md` maps every old command, flag and environment variable to its replacement.

## Issues

fixes #1118
fixes #1116
fixes #1115
fixes #1094
fixes #1091
fixes #1073
fixes #1052
fixes #1032
fixes #1023
fixes #966
fixes #908
fixes #833
fixes #831
fixes #817
fixes #804
fixes #779
fixes #770
fixes #737
fixes #697
fixes #726
fixes #677
fixes #672
fixes #633
fixes #632
fixes #560
fixes #556
fixes #523
fixes #516
fixes #510
fixes #504
fixes #500
fixes #482
fixes #406
fixes #403
fixes #373
fixes #351
fixes #344
fixes #326
fixes #325
fixes #323
fixes #246
fixes #240
fixes #232
fixes #197
fixes #172
fixes #141
fixes #69
fixes #1110
fixes #569
fixes #480
fixes #666
fixes #670
fixes #457
fixes #643
fixes #498
fixes #490
fixes #1069
fixes #834
fixes #602
fixes #328
fixes #417
fixes #571
fixes #1029
fixes #489
fixes #1050
fixes #162
fixes #430
fixes #1087
fixes #683

Reviewed-on: https://gitea.com/gitea/tea/pulls/1126
Reviewed-by: TheFox0x7 <95654+thefox0x7@noreply.gitea.com>
2026-10-11 17:23:06 +00:00

145 lines
4.4 KiB
Go

// Copyright 2026 The Gitea Authors. All rights reserved.
// SPDX-License-Identifier: MIT
package app
import (
"errors"
"fmt"
"strings"
"gitea.dev/tea/internal/clierr"
"gitea.dev/tea/internal/services"
"gitea.dev/tea/internal/terminal"
"github.com/spf13/cobra"
)
func (a *application) pullReviewLifecycleCommand(verb string) *cobra.Command {
var body, file, event string
var useEditor bool
cmd := &cobra.Command{Use: verb + " <number> <review-id>", Short: titleCase(verb) + " a pull request review", Args: argsExact(2), RunE: func(cmd *cobra.Command, args []string) (runErr error) {
var draft terminal.Draft
defer finishDraft(&draft, &runErr)
if err := validateBodySources(cmd); err != nil {
return err
}
n, err := number(args[0])
if err != nil {
return err
}
id, err := number(args[1])
if err != nil {
return err
}
if verb == "submit" {
if err := oneOf("event", event, "APPROVED", "REQUEST_CHANGES", "COMMENT"); err != nil {
return err
}
}
var suppliedBody *string
if verb == "submit" || verb == "dismiss" {
body, err = a.readBody(cmd, body, file)
if err != nil {
return err
}
if cmd.Flags().Changed("body") || cmd.Flags().Changed("body-file") {
suppliedBody = &body
}
if verb == "dismiss" {
if suppliedBody == nil && !useEditor {
if _, err := a.require(cmd, &body, "body"); err != nil {
return err
}
}
if strings.TrimSpace(body) == "" && !useEditor {
return clierr.Wrap(clierr.Usage, errors.New("supply a non-empty dismissal reason with --body or --body-file"))
}
} else if suppliedBody != nil && strings.TrimSpace(body) == "" && event == "REQUEST_CHANGES" {
return clierr.Wrap(clierr.Usage, errors.New("review body cannot be empty for REQUEST_CHANGES"))
}
}
target, err := a.resolve(cmd.Context(), true)
if err != nil {
return err
}
service := services.Reviews{Client: target.client, Repository: target.Repo}
if useEditor {
initial := ""
if verb == "submit" {
current, err := service.View(cmd.Context(), n, id)
if err != nil {
return err
}
initial = current.Body
}
draft, err = a.editDraft(cmd, initial)
if err != nil {
return err
}
body = draft.Body
suppliedBody = &body
if strings.TrimSpace(body) == "" && (verb == "dismiss" || event == "REQUEST_CHANGES") {
return clierr.Wrap(clierr.Usage, errors.New("supply non-empty review text in the editor"))
}
}
if verb == "delete" || verb == "dismiss" {
message := fmt.Sprintf("%s review %d on %s#%d", verb, id, target.Repo, n)
if verb == "dismiss" {
message += ": " + body
}
if err := a.confirm(cmd, message); err != nil {
return err
}
}
if verb == "submit" && event == "REQUEST_CHANGES" && suppliedBody == nil {
current, err := service.View(cmd.Context(), n, id)
if err != nil {
return err
}
body = current.Body
if strings.TrimSpace(body) == "" {
body = ""
if _, err := a.require(cmd, &body, "body"); err != nil {
return err
}
if strings.TrimSpace(body) == "" {
return clierr.Wrap(clierr.Usage, errors.New("review body cannot be empty for REQUEST_CHANGES"))
}
if err := a.confirm(cmd, fmt.Sprintf("Submit REQUEST_CHANGES review on %s#%d: %s", target.Repo, n, body)); err != nil {
return err
}
}
suppliedBody = &body
}
if verb == "delete" {
if err := service.Delete(cmd.Context(), n, id); err != nil {
return err
}
_, err := fmt.Fprintf(cmd.ErrOrStderr(), "Deleted review %d\n", id)
return err
}
var item services.Review
if verb == "submit" {
item, err = service.Submit(cmd.Context(), n, id, services.ReviewSubmitOptions{Event: event, Body: suppliedBody})
} else {
item, err = service.Dismiss(cmd.Context(), n, id, verb == "dismiss", body)
}
if err != nil {
return err
}
return writeRecord(a, cmd, item, reviewRecord)
}}
if verb == "submit" || verb == "dismiss" {
cmd.Flags().BoolVar(&useEditor, "editor", false, "Edit review text in the configured editor")
cmd.Flags().StringVar(&body, "body", "", "Review body or dismissal reason (submission preserves draft body when omitted)")
cmd.Flags().StringVar(&file, "body-file", "", "Read body from file, or - for stdin")
}
if verb == "submit" {
cmd.Flags().StringVar(&event, "event", "COMMENT", "Review event: APPROVED, REQUEST_CHANGES, COMMENT")
}
if verb == "delete" {
cmd.Annotations = textOutput("review deletion does not return a resource")
}
return cmd
}