Files
gitea-tea/internal/app/milestone_names_test.go
T
bircni f02245449b feat!: rebuild tea on Cobra with explicit noun/verb commands (#1126)
- **switch tea to the Cobra command tree:** `internal/app` wires the packages from parts 1–4 into explicit noun/verb commands with `--repo`, `--json` / `--jq`, `--sudo` and `--debug`; `main.go` points at it. Build, release and docs tooling (`tools/cli-docs`, Makefile, goreleaser, snap, CI) and README / CONTRIBUTING are updated.
- **remove the urfave/cli command tree:** deletes `cmd/`, `modules/`, the old integration tests, contrib completion scripts and the generated `docs/CLI.md`, and drops their dependencies. This commit only deletes.

## Breaking changes

This is a breaking release. It requires Gitea 28 or newer; configuration moves to separate `config.yml` and `hosts.yml` files and requires fresh authentication, and command names, aliases, flags and output formats change. `docs/migration-1.0.md` maps every old command, flag and environment variable to its replacement.

## Issues

fixes #1118
fixes #1116
fixes #1115
fixes #1094
fixes #1091
fixes #1073
fixes #1052
fixes #1032
fixes #1023
fixes #966
fixes #908
fixes #833
fixes #831
fixes #817
fixes #804
fixes #779
fixes #770
fixes #737
fixes #697
fixes #726
fixes #677
fixes #672
fixes #633
fixes #632
fixes #560
fixes #556
fixes #523
fixes #516
fixes #510
fixes #504
fixes #500
fixes #482
fixes #406
fixes #403
fixes #373
fixes #351
fixes #344
fixes #326
fixes #325
fixes #323
fixes #246
fixes #240
fixes #232
fixes #197
fixes #172
fixes #141
fixes #69
fixes #1110
fixes #569
fixes #480
fixes #666
fixes #670
fixes #457
fixes #643
fixes #498
fixes #490
fixes #1069
fixes #834
fixes #602
fixes #328
fixes #417
fixes #571
fixes #1029
fixes #489
fixes #1050
fixes #162
fixes #430
fixes #1087
fixes #683

Reviewed-on: https://gitea.com/gitea/tea/pulls/1126
Reviewed-by: TheFox0x7 <95654+thefox0x7@noreply.gitea.com>
2026-10-11 17:23:06 +00:00

118 lines
4.4 KiB
Go

// Copyright 2026 The Gitea Authors. All rights reserved.
// SPDX-License-Identifier: MIT
package app
import (
"context"
"encoding/json"
"net/http"
"testing"
"github.com/stretchr/testify/require"
)
func TestMilestoneNameSelectionResolvesAllPagesBeforeEditing(t *testing.T) {
duplicate := false
edits := 0
server := newAuthenticatedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if r.Method == http.MethodGet {
if r.URL.Path == "/api/v1/repos/alice/project/milestones/9" {
_, _ = w.Write([]byte(`{"id":9,"title":"Release one"}`))
return
}
require.Equal(t, "/api/v1/repos/alice/project/milestones", r.URL.Path)
require.Equal(t, "all", r.URL.Query().Get("state"))
switch r.URL.Query().Get("page") {
case "1":
_, _ = w.Write([]byte(`[{"id":9,"title":"Release one"}]`))
case "2":
if duplicate {
_, _ = w.Write([]byte(`[{"id":10,"title":"Release one"}]`))
} else {
_, _ = w.Write([]byte(`[]`))
}
default:
_, _ = w.Write([]byte(`[]`))
}
return
}
edits++
require.Equal(t, http.MethodPatch, r.Method)
require.Equal(t, "/api/v1/repos/alice/project/milestones/9", r.URL.Path)
_, _ = w.Write([]byte(`{"id":9,"title":"Release one","state":"closed"}`))
}))
defer server.Close()
deps, out, _ := serverDeps(t, server.URL)
args := []string{"milestone", "close", "Release one", "--by-name", "-R", "alice/project", "--json=id,state"}
require.NoError(t, Execute(context.Background(), deps, args))
require.JSONEq(t, `{"id":9,"state":"closed"}`, out.String())
duplicate = true
out.Reset()
require.ErrorContains(t, Execute(context.Background(), deps, args), "ambiguous")
require.Empty(t, out.String())
require.Equal(t, 1, edits)
}
func TestMilestoneDeleteReturnsJSONSnapshotOnlyAfterSuccess(t *testing.T) {
calls := []string{}
fail := false
server := newAuthenticatedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
require.Equal(t, "/api/v1/repos/alice/project/milestones/9", r.URL.Path)
calls = append(calls, r.Method)
if r.Method == http.MethodGet {
_, _ = w.Write([]byte(`{"id":9,"title":"Release one","state":"open"}`))
return
}
require.Equal(t, http.MethodDelete, r.Method)
if fail {
w.WriteHeader(403)
} else {
w.WriteHeader(204)
}
}))
defer server.Close()
deps, out, _ := serverDeps(t, server.URL)
args := []string{"milestone", "delete", "9", "-R", "alice/project", "--yes", "--json=id,title"}
require.NoError(t, Execute(context.Background(), deps, args))
require.JSONEq(t, `{"id":9,"title":"Release one"}`, out.String())
require.Equal(t, []string{"GET", "DELETE"}, calls)
fail = true
out.Reset()
require.Error(t, Execute(context.Background(), deps, args))
require.Empty(t, out.String())
}
func TestMilestoneIssueCommandsSelectByName(t *testing.T) {
var calls []string
server := newAuthenticatedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
calls = append(calls, r.Method+" "+r.URL.Path)
switch {
case r.URL.Path == "/api/v1/repos/alice/project/milestones":
if r.URL.Query().Get("page") == "1" {
_, _ = w.Write([]byte(`[{"id":9,"title":"Release one"}]`))
return
}
_, _ = w.Write([]byte(`[]`))
case r.URL.Path == "/api/v1/repos/alice/project/issues" && r.Method == http.MethodGet:
require.Equal(t, "9", r.URL.Query().Get("milestones"))
_, _ = w.Write([]byte(`[]`))
case r.URL.Path == "/api/v1/repos/alice/project/issues/3" && r.Method == http.MethodPatch:
var payload map[string]any
require.NoError(t, json.NewDecoder(r.Body).Decode(&payload))
require.EqualValues(t, 9, payload["milestone"])
_, _ = w.Write([]byte(`{"number":3,"milestone":{"id":9}}`))
default:
t.Errorf("unexpected %s %s", r.Method, r.URL.Path)
w.WriteHeader(http.StatusNotFound)
}
}))
defer server.Close()
deps, _, _ := serverDeps(t, server.URL)
require.NoError(t, Execute(context.Background(), deps, []string{"milestone", "issue", "list", "Release one", "--by-name", "-R", "alice/project", "--json"}))
require.NoError(t, Execute(context.Background(), deps, []string{"milestone", "issue", "add", "Release one", "3", "--by-name", "-R", "alice/project", "--json=number"}))
require.NotContains(t, calls, "GET /api/v1/repos/alice/project/milestones/9")
err := Execute(context.Background(), deps, []string{"milestone", "issue", "remove", " ", "3", "--by-name", "-R", "alice/project"})
require.ErrorContains(t, err, "milestone name cannot be empty")
}