mirror of
https://gitea.com/gitea/tea.git
synced 2026-10-26 19:11:25 +01:00
bircni
83924892ff
services.IsNotFound replaces the hand-rolled 404 checks, convertPage the copied page conversions and lastPathNumber the comment's own number parser. The List wrappers around ListPage of releases, branches, wiki pages, secrets and variables go, pull request filters resolve milestones through Milestones.FindOne like issues, and localFlagsChanged, boolOrder, Cell.Render, stateBadge and dueText replace their copies. Signed-off-by: bircni <bircni@icloud.com>
44 lines
1.3 KiB
Go
44 lines
1.3 KiB
Go
// Copyright 2026 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package services
|
|
|
|
import (
|
|
"context"
|
|
"net/http"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestMilestoneNamesIncludeClosedAndRejectAmbiguity(t *testing.T) {
|
|
duplicate := false
|
|
client := newTestClient(t, http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
require.Equal(t, http.MethodGet, r.Method)
|
|
require.Equal(t, "all", r.URL.Query().Get("state"))
|
|
switch r.URL.Query().Get("page") {
|
|
case "1":
|
|
_, _ = w.Write([]byte(`[{"id":1,"title":"Other"}]`))
|
|
case "2":
|
|
_, _ = w.Write([]byte(`[{"id":2,"title":"Release","state":"closed"}]`))
|
|
case "3":
|
|
if duplicate {
|
|
_, _ = w.Write([]byte(`[{"id":3,"title":"Release"}]`))
|
|
return
|
|
}
|
|
fallthrough
|
|
default:
|
|
_, _ = w.Write([]byte(`[]`))
|
|
}
|
|
}))
|
|
service := Milestones{Client: client, Repository: "alice/project"}
|
|
item, err := service.FindOne(context.Background(), "Release", false)
|
|
require.NoError(t, err)
|
|
require.EqualValues(t, 2, item.ID)
|
|
_, err = service.FindOne(context.Background(), "missing", false)
|
|
require.ErrorContains(t, err, "not found")
|
|
duplicate = true
|
|
_, err = service.FindOne(context.Background(), "Release", false)
|
|
require.ErrorContains(t, err, "ambiguous")
|
|
}
|