gitea-tea/internal/services/review_requests_test.go

// Copyright 2026 The Gitea Authors. All rights reserved.
// SPDX-License-Identifier: MIT

package services

import (
	"context"
	"encoding/json"
	"net/http"
	"net/http/httptest"
	"testing"

	"gitea.dev/tea/internal/transport"
	"github.com/stretchr/testify/assert"
	"github.com/stretchr/testify/require"
)

func TestReviewRequestNamesValidatedBeforeNetwork(t *testing.T) {
	for _, changes := range []ReviewRequestChanges{
		{},
		{Add: ReviewRequestInput{Users: []string{""}}},
		{Add: ReviewRequestInput{Teams: []string{" team"}}},
		{Add: ReviewRequestInput{Users: []string{"Alice", "alice"}}},
		{Add: ReviewRequestInput{Users: []string{"Alice"}}, Remove: ReviewRequestInput{Users: []string{"alice"}}},
		{Add: ReviewRequestInput{Teams: []string{"Team"}}, Remove: ReviewRequestInput{Teams: []string{"team"}}},
	} {
		require.Error(t, changes.Validate())
	}
	require.NoError(t, (ReviewRequestChanges{Add: ReviewRequestInput{Users: []string{"alice@example.test"}, Teams: []string{"alice"}}}).Validate())
}

func TestReviewRequestPartialFailureStopsFurtherEdits(t *testing.T) {
	mutations := 0
	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
		mutations++
		require.Equal(t, "/api/v1/repos/owner/repo/pulls/1/requested_reviewers", r.URL.Path)
		var input ReviewRequestInput
		assert.NoError(t, json.NewDecoder(r.Body).Decode(&input))
		if mutations == 1 {
			require.Equal(t, http.MethodDelete, r.Method)
			assert.Equal(t, ReviewRequestInput{Users: []string{"alice"}}, input)
			w.WriteHeader(http.StatusNoContent)
		} else {
			require.Equal(t, http.MethodPost, r.Method)
			assert.Equal(t, ReviewRequestInput{Users: []string{"bob"}}, input)
			w.WriteHeader(http.StatusForbidden)
		}
	}))
	defer server.Close()
	title := "New title"
	changes := ReviewRequestChanges{Remove: ReviewRequestInput{Users: []string{"alice"}}, Add: ReviewRequestInput{Users: []string{"bob"}}}
	_, err := (Pulls{Client: transport.New(server.URL, "", false), Repository: "owner/repo"}).Edit(context.Background(), 1, PullEdit{Title: &title, ReviewerChanges: &changes})
	require.ErrorContains(t, err, "reviewer removals succeeded")
	require.Equal(t, 2, mutations)
}

func TestReviewerTeamCheckSkippedWhenTeamListingIsForbidden(t *testing.T) {
	var posted bool
	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
		switch {
		case r.URL.Path == "/api/v1/orgs/owner":
			_, _ = w.Write([]byte(`{"id":1}`))
		case r.URL.Path == "/api/v1/orgs/owner/teams":
			w.WriteHeader(http.StatusForbidden)
			_, _ = w.Write([]byte(`{"message":"Must be an organization member"}`))
		case r.Method == http.MethodPost && r.URL.Path == "/api/v1/repos/owner/repo/pulls/1/requested_reviewers":
			posted = true
			w.WriteHeader(http.StatusCreated)
			_, _ = w.Write([]byte(`[]`))
		default:
			_, _ = w.Write([]byte(`{"number":1}`))
		}
	}))
	defer server.Close()
	changes := ReviewRequestChanges{Add: ReviewRequestInput{Teams: []string{"devs"}}}
	_, err := (Reviews{Client: transport.New(server.URL, "", false), Repository: "owner/repo"}).ChangeRequests(context.Background(), 1, changes)
	require.NoError(t, err)
	require.True(t, posted, "the server decides whether the team exists")
}

func TestUnknownReviewerTeamRejectsBeforeUserRemoval(t *testing.T) {
	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
		require.Equal(t, http.MethodGet, r.Method)
		switch r.URL.Path {
		case "/api/v1/orgs/owner":
			_, _ = w.Write([]byte(`{"id":1}`))
		case "/api/v1/orgs/owner/teams":
			_, _ = w.Write([]byte(`[]`))
		default:
			t.Errorf("unexpected request: %s", r.URL.Path)
		}
	}))
	defer server.Close()
	changes := ReviewRequestChanges{Remove: ReviewRequestInput{Users: []string{"alice"}}, Add: ReviewRequestInput{Teams: []string{"missing"}}}
	_, err := (Reviews{Client: transport.New(server.URL, "", false), Repository: "owner/repo"}).ChangeRequests(context.Background(), 1, changes)
	require.ErrorContains(t, err, `team "missing" is unavailable`)
}