From d2f1a295a15f0fa60f6e07c435b229b6e0491451 Mon Sep 17 00:00:00 2001 From: Joe Testa Date: Thu, 18 Apr 2024 19:36:13 -0400 Subject: [PATCH] Removed vulture from Tox (it rarely made any findings, and when it did, pylint reported the same issues). --- .github/workflows/tox.yaml | 2 +- tox.ini | 18 +++--------------- 2 files changed, 4 insertions(+), 16 deletions(-) diff --git a/.github/workflows/tox.yaml b/.github/workflows/tox.yaml index 50f5012..e1506e4 100644 --- a/.github/workflows/tox.yaml +++ b/.github/workflows/tox.yaml @@ -18,7 +18,7 @@ jobs: - name: Install dependencies run: | python -m pip install --upgrade pip - pip install -U codecov coveralls flake8 mypy pylint pytest tox vulture + pip install -U codecov coveralls flake8 mypy pylint pytest tox - name: Run Tox run: | tox diff --git a/tox.ini b/tox.ini index b06c290..13ccfc7 100644 --- a/tox.ini +++ b/tox.ini @@ -1,7 +1,7 @@ [tox] envlist = - py{py3}-{test,pylint,flake8,vulture} - py{38,39,310,311,312}-{test,mypy,pylint,flake8,vulture} + py{py3}-{test,pylint,flake8} + py{38,39,310,311,312}-{test,mypy,pylint,flake8} cov skip_missing_interpreters = true @@ -13,7 +13,6 @@ deps = py{38,39,310,311,312}-{type,mypy}: {[testenv:mypy]deps} py{py3,38,39,310,311,312}-{lint,pylint},lint: {[testenv:pylint]deps} py{py3,38,39,310,311,312}-{lint,flake8},lint: {[testenv:flake8]deps} - py{py3,38,39,310,311,312}-{lint,vulture},lint: {[testenv:vulture]deps} setenv = SSHAUDIT = {toxinidir}/src test: COVERAGE_FILE = {toxinidir}/.coverage.{envname} @@ -28,7 +27,7 @@ commands = py{38,39,310,311,312}-{type,mypy}: {[testenv:mypy]commands} py{py3,38,39,310,311,312}-{lint,pylint},lint: {[testenv:pylint]commands} py{py3,38,39,310,311,312}-{lint,flake8},lint: {[testenv:flake8]commands} - py{py3,38,39,310,311,312}-{lint,vulture},lint: {[testenv:vulture]commands} + #ignore_outcome = # type: true # lint: true @@ -75,17 +74,6 @@ deps = commands = flake8 {posargs:{env:SSHAUDIT} {toxinidir}/setup.py {toxinidir}/test {toxinidir}/ssh-audit.py} --statistics -[testenv:vulture] -deps = - vulture -commands = - python -c "import sys; from subprocess import Popen, PIPE; \ - a = ['vulture', '--min-confidence', '100'] + r'{posargs:{env:SSHAUDIT}}'.split(' '); \ - o = Popen(a, shell=False, stdout=PIPE).communicate()[0]; \ - l = [x for x in o.split(b'\n') if x and b'Unused import' not in x]; \ - print(b'\n'.join(l).decode('utf-8')); \ - sys.exit(1 if len(l) > 0 else 0)" - [pylint] reports = no #output-format = colorized