* Move files for better setup.py packaging
* Update setup.py and configs for src layout
* Run tests on setup.py build
In effect, this tests that the setup.py configuration is correct.
coverage combine and coverage:paths are added to keep the displayed
coverage paths as src/ssh_audit/*.py instead of
.tox/$envname/**/site-packages/ssh_audit/*.py
* Remove unnecessary encoding declarations
Python 3 defaults to UTF-8 encoding.
https://docs.python.org/3/reference/lexical_analysis.html#encoding-declarations
* Remove shebang from colorama type stubs
Shouldn't need to be an executable.
Related: git has this file tracked as chmod -x.
* Remove mypy job for Python 2
modified: tox.ini
* Remove Python 2 compatibility import
modified: ssh-audit.py
* Remove compatibility import for BytesIO and StringIO
This is no longer necessary, as support for Python 2 was dropped.
modified: ssh-audit.py
* Remove `text-type` compatibility layer
... as support for Python 2 was dropped already.
modified: ssh-audit.py
* Remove `binary-type` compatibility layer
... as support for Python 2 was dropped already.
modified: ssh-audit.py
* Remove try-except block for typing
... as since Python 3.5 it is included in the standard library.
modified: ssh-audit.py
* Move typing import to top of module
modified: ssh-audit.py
* Remove obsolete encoding declaration
modified: ssh-audit.py
* Apply pyupgrade on ssh-audit.py
pyupgrade is a tool which updates Python code to modern syntax
modified: ssh-audit.py
* Remove Python 2 compatibility from conftest.py
modified: test/conftest.py
* Remove Python 2 compatibility from test_auditconf.py
modified: test/test_auditconf.py
* Remove Python 2 compatibility from test_banner.py
modified: test/test_banner.py
* Remove Python 2 compatibility from test_buffer.py
modified: test/test_buffer.py
* Remove Python 2 compatibility from test_errors.py
modified: test/test_errors.py
* Remove Python 2 compatibility from test_output.py
modified: test/test_output.py
* Remove Python 2 compatibility from test_resolve.py
modified: test/test_resolve.py
* Remove Python 2 compatibility from test_socket.py
modified: test/test_socket.py
* Remove Python 2 compatibility from test_software.py
modified: test/test_software.py
* Remove Python 2 compatibility from test_ssh_algorithm.py
modified: test/test_ssh_algorithm.py
* Remove Python 2 compatibility from test_ssh1.py
modified: test/test_ssh1.py
* Remove Python 2 compatibility from test_ssh2.py
modified: test/test_ssh2.py
* Remove Python 2 compatibility and Py2 only tests
... from test_utils.py.
modified: test/test_utils.py
* Remove Python 2 compatibility from test_version_compare.py
modified: test/test_version_compare.py
* Remove Python 2 job from appveyor config
This was done blindly, as it is unclear whether appveyor runs at all.
modified: .appveyor.yml
* Apply Flake8 also on `setup.py`
modified: tox.ini
* Fix W605 - invalid escape syntax
modified: packages/setup.py
modified: tox.ini
* Update comment about Flake8: W504
W503 and W504 are mutual exclusive - so we have to keep one of them.
modified: tox.ini
* Fix F841 - variable assigned but never used
modified: ssh-audit.py
modified: tox.ini
* Fix E741 - ambiguous variable name 'l'
modified: ssh-audit.py
modified: tox.ini
* Fix E712 - comparison to False should be 'if cond is False'
... and not 'if conf == False'.
modified: ssh-audit.py
modified: tox.ini
* Fix E711 - comparison to None should be 'if cond is not None'
... and not 'if cond != None'.
modified: ssh-audit.py
modified: tox.ini
* Fix E305 - expected 2 blank lines
... after class or function definition, found 1.
modified: ssh-audit.py
modified: tox.ini
* Fix E303 - too many blank lines
modified: ssh-audit.py
modified: tox.ini
* Fix E303 - too many blank lines
modified: ssh-audit.py
modified: tox.ini
* Fix E301 - expected 1 blank line, found 0
No code change necessary, probably fixed by another commit.
modified: tox.ini
* Fix E265 - block comment should start with '# '
There is lots of commented out code, which usually should be just
deleted.
I will keep it for now, as I am not yet very familiar with the code
base.
modified: ssh-audit.py
modified: tox.ini
* Fix E261 - at least two spaces before inline comment
modified: ssh-audit.py
modified: tox.ini
* Fix E251 - unexpected spaces around keyword / parameter equals
modified: packages/setup.py
modified: tox.ini
* Fix E231 - missing whitespace after ','
No code change necessary, probably fixed by previous commit.
modified: tox.ini
* Fix E226 - missing whitespace around arithmetic operator
modified: ssh-audit.py
modified: tox.ini
* Fix W293 - blank line contains whitespace
modified: ssh-audit.py
modified: tox.ini
* Fix E221 - multiple spaces before operator
modified: ssh-audit.py
modified: tox.ini
* Update comment about Flake 8 E241
Lots of data is formatted as tables, so this warning is disabled for a
good reason.
modified: tox.ini
* Fix E401 - multiple imports on one line
modified: ssh-audit.py
modified: tox.ini
* Do not ignore Flake8 warning F401
... as there were no errors in source code anyway.
modified: tox.ini
* Fix F821 - undefined name
modified: ssh-audit.py
modified: tox.ini
* Reformat ignore section for Flake8
modified: tox.ini
* Flake8 test suite
modified: test/conftest.py
modified: test/test_auditconf.py
modified: test/test_banner.py
modified: test/test_buffer.py
modified: test/test_errors.py
modified: test/test_output.py
modified: test/test_resolve.py
modified: test/test_socket.py
modified: test/test_software.py
modified: test/test_ssh1.py
modified: test/test_ssh2.py
modified: test/test_ssh_algorithm.py
modified: test/test_utils.py
modified: test/test_version_compare.py
modified: tox.ini
By default both IPv4 and IPv6 is supported and order of precedence depends on OS.
By using -46, IPv4 is prefered, but by using -64, IPv6 is preferd.
For now the old way how to specify port (host:port) has been kept intact.
Ganden Schaffner
Jürgen Gmach
Joe Testa
Andris Raugulis