Git/testssl.sh
1
0
Fork 0
mirror of https://github.com/drwetter/testssl.sh.git synced 2026-09-20 16:48:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3140 from dcooper16/fix_SC2076

Browse Source 
Fix Shellcheck SC2076
This commit is contained in:
Dirk Wetter
2026-09-14 09:42:47 +02:00
committed by GitHub
parent 98bd9d66a4 85e71adaa2
commit 06c1955f63
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
testssl.sh
+6 -6
View File
@@ -8417,7 +8417,7 @@ extract_new_tls_extensions() {
if [[ -n "$tls_extensions" ]]; then if [[ -n "$tls_extensions" ]]; then
# check to see if any new TLS extensions were returned and add any new ones to TLS_EXTENSIONS # check to see if any new TLS extensions were returned and add any new ones to TLS_EXTENSIONS
while read -d "\"" -r line; do while read -d "\"" -r line; do
if [[ $line != "" ]] && [[ ! "${TLS_EXTENSIONS[*]}" =~ "$line" ]]; then if [[ $line != "" ]] && [[ ! "${TLS_EXTENSIONS[*]}" =~ $line ]]; then
i=${#TLS_EXTENSIONS[*]} i=${#TLS_EXTENSIONS[*]}
while [[ $i -gt 0 ]] && [[ ${TLS_EXTENSIONS[i-1]#*/#} -gt ${line#*/#} ]]; do while [[ $i -gt 0 ]] && [[ ${TLS_EXTENSIONS[i-1]#*/#} -gt ${line#*/#} ]]; do
TLS_EXTENSIONS[i]="${TLS_EXTENSIONS[i-1]}" TLS_EXTENSIONS[i]="${TLS_EXTENSIONS[i-1]}"
@@ -9343,7 +9343,7 @@ must_staple() {
# probably okay, since it seems likely that any TLS Feature extension # probably okay, since it seems likely that any TLS Feature extension
# that includes status_request_v2 will also include status_request. # that includes status_request_v2 will also include status_request.
supported=true supported=true
elif [[ "$hostcert_txt" =~ '1.3.6.1.5.5.7.1.24:' ]]; then elif [[ "$hostcert_txt" =~ 1\.3\.6\.1\.5\.5\.7\.1\.24: ]]; then
cert="$($OPENSSL x509 -in "$HOSTCERT" -outform DER 2>>$ERRFILE | hexdump -v -e '16/1 "%02X"')" cert="$($OPENSSL x509 -in "$HOSTCERT" -outform DER 2>>$ERRFILE | hexdump -v -e '16/1 "%02X"')"
extn="${cert##*06082B06010505070118}" extn="${cert##*06082B06010505070118}"
# Check for critical bit, and skip over it if present. # Check for critical bit, and skip over it if present.
@@ -9408,11 +9408,11 @@ certificate_transparency() {
# server's certificate. If they aren't, check whether the server provided # server's certificate. If they aren't, check whether the server provided
# a stapled OCSP response with SCTs. If no SCTs were found in the certificate # a stapled OCSP response with SCTs. If no SCTs were found in the certificate
# or OCSP response, check for an SCT TLS extension. # or OCSP response, check for an SCT TLS extension.
if [[ "$cert_txt" =~ CT\ Precertificate\ SCTs ]] || [[ "$cert_txt" =~ '1.3.6.1.4.1.11129.2.4.2' ]]; then if [[ "$cert_txt" =~ CT\ Precertificate\ SCTs ]] || [[ "$cert_txt" =~ 1\.3\.6\.1\.4\.1\.11129\.2\.4\.2 ]]; then
CERTIFICATE_TRANSPARENCY_SOURCE="certificate extension" CERTIFICATE_TRANSPARENCY_SOURCE="certificate extension"
return 0 return 0
fi fi
if [[ "$ocsp_response" =~ CT\ Certificate\ SCTs ]] || [[ "$ocsp_response" =~ '1.3.6.1.4.1.11129.2.4.5' ]]; then if [[ "$ocsp_response" =~ CT\ Certificate\ SCTs ]] || [[ "$ocsp_response" =~ 1\.3\.6\.1\.4\.1\.11129\.2\.4\.5 ]]; then
CERTIFICATE_TRANSPARENCY_SOURCE="OCSP extension" CERTIFICATE_TRANSPARENCY_SOURCE="OCSP extension"
return 0 return 0
fi fi
@@ -22809,7 +22809,7 @@ get_caa_rrecord() {
raw_caa="$(drill $1 type257 | awk '/'"^${1}"'.*CAA/ { print $5,$6,$7 }')" raw_caa="$(drill $1 type257 | awk '/'"^${1}"'.*CAA/ { print $5,$6,$7 }')"
elif "$HAS_HOST"; then elif "$HAS_HOST"; then
raw_caa="$(host -t type257 $1)" raw_caa="$(host -t type257 $1)"
if [[ "$raw_caa" =~ "has no CAA|has no TYPE257" ]]; then if [[ "$raw_caa" =~ has\ no\ CAA|has\ no\ TYPE257 ]]; then
raw_caa="" raw_caa=""
else else
raw_caa="${raw_caa/$1 has CAA record /}" raw_caa="${raw_caa/$1 has CAA record /}"
@@ -22936,7 +22936,7 @@ get_https_rrecord() {
# empty if there's no such record # empty if there's no such record
elif "$HAS_HOST"; then elif "$HAS_HOST"; then
raw_https="$(host -t type65 "$1")" raw_https="$(host -t type65 "$1")"
if [[ "$raw_https" =~ "has no HTTPS|has no TYPE65" ]]; then if [[ "$raw_https" =~ has\ no\ HTTPS|has\ no\ TYPE65 ]]; then
raw_https="" raw_https=""
else else
raw_https="${raw_https/$1 has HTTPS record /}" raw_https="${raw_https/$1 has HTTPS record /}"