From 00476b751a94b16cd5cc0440394149ed202fb0e6 Mon Sep 17 00:00:00 2001 From: Dirk Wetter Date: Sat, 15 Nov 2025 13:39:09 +0100 Subject: [PATCH 1/3] Ignore files types for shellcheck --- .github/workflows/shellcheck.yml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/.github/workflows/shellcheck.yml b/.github/workflows/shellcheck.yml index 9e58ae1..0ba03ec 100644 --- a/.github/workflows/shellcheck.yml +++ b/.github/workflows/shellcheck.yml @@ -1,6 +1,19 @@ --- name: Shellcheck on: [pull_request] + paths-ignore: + - 'utils/**' + - 'doc/**' + - 'bin/**' + - '**.md' + - '**.1' + - '**.html' + - '**.pem' + - '**.pdf' + - '**.yml' + - 'LICENSE' + - 'Dockerfile' + - 'Dockerfile.alpine' permissions: contents: read From c07d17ea8f516d1ce26acddabf5126a383fad6b6 Mon Sep 17 00:00:00 2001 From: Dirk Wetter Date: Sat, 15 Nov 2025 13:56:19 +0100 Subject: [PATCH 2/3] Fix indentation + comment wrt paths_ignore --- .github/workflows/shellcheck.yml | 33 ++++++++++++++++++-------------- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/.github/workflows/shellcheck.yml b/.github/workflows/shellcheck.yml index 0ba03ec..b3b579a 100644 --- a/.github/workflows/shellcheck.yml +++ b/.github/workflows/shellcheck.yml @@ -1,19 +1,24 @@ +# Runs shellcheck on code -- in error mode only. +# "paths-ignore" should be in line with unit_test.*yml files --- name: Shellcheck -on: [pull_request] - paths-ignore: - - 'utils/**' - - 'doc/**' - - 'bin/**' - - '**.md' - - '**.1' - - '**.html' - - '**.pem' - - '**.pdf' - - '**.yml' - - 'LICENSE' - - 'Dockerfile' - - 'Dockerfile.alpine' + +on: + pull_request: + paths-ignore: + - 'utils/**' + - 'doc/**' + - 'bin/**' + - '**.md' + - '**.1' + - '**.html' + - '**.pem' + - '**.pdf' + - '**.yml' + - 'LICENSE' + - 'Dockerfile' + - 'Dockerfile.alpine' + permissions: contents: read From fd97a752415f5abe56be220685e73e7c2cc51fc6 Mon Sep 17 00:00:00 2001 From: Dirk Wetter Date: Sat, 15 Nov 2025 14:05:08 +0100 Subject: [PATCH 3/3] Add comments for paths_ignore --- .github/workflows/unit_tests_macos.yml | 2 ++ .github/workflows/unit_tests_ubuntu.yml | 2 ++ 2 files changed, 4 insertions(+) diff --git a/.github/workflows/unit_tests_macos.yml b/.github/workflows/unit_tests_macos.yml index b6f6517..507ddba 100644 --- a/.github/workflows/unit_tests_macos.yml +++ b/.github/workflows/unit_tests_macos.yml @@ -1,3 +1,5 @@ +# "paths-ignore" should be in line with unit_tests_ubuntu.yml +# and shellcheck.yml --- name: CI run MacOS diff --git a/.github/workflows/unit_tests_ubuntu.yml b/.github/workflows/unit_tests_ubuntu.yml index a95bb7b..fd116ae 100644 --- a/.github/workflows/unit_tests_ubuntu.yml +++ b/.github/workflows/unit_tests_ubuntu.yml @@ -1,3 +1,5 @@ +# "paths-ignore" should be in line with unit_tests_macos.yml +# and shellcheck.yml --- name: CI run Ubuntu