Merge pull request #503 from AlGreed/2.9dev

new pretty JSON format + severity level filter
This commit is contained in:
Dirk Wetter 2016-11-04 07:22:25 +01:00 committed by GitHub
commit 1d461307be
3 changed files with 329 additions and 141 deletions

4
.gitignore vendored
View File

@ -1,3 +1,7 @@
.DS_Store .DS_Store
tmp.json tmp.json
*.bak *.bak
*.xml
*.iml

View File

@ -28,7 +28,7 @@ foreach my $f ( @$json ) {
if ( $f->{id} eq "expiration" ) { if ( $f->{id} eq "expiration" ) {
$found = 1; $found = 1;
like($f->{finding},qr/^Certificate Expiration.*expired\!/,"Finding reads expired."); $tests++; like($f->{finding},qr/^Certificate Expiration.*expired\!/,"Finding reads expired."); $tests++;
is($f->{severity}, "NOT ok", "Severity should be NOT ok"); $tests++; is($f->{severity}, "CRITICAL", "Severity should be CRITICAL"); $tests++;
last; last;
} }
} }
@ -56,7 +56,7 @@ foreach my $f ( @$json ) {
if ( $f->{id} eq "chain_of_trust" ) { if ( $f->{id} eq "chain_of_trust" ) {
$found = 1; $found = 1;
like($f->{finding},qr/^All certificate trust checks failed/,"Finding says certificate cannot be trusted."); $tests++; like($f->{finding},qr/^All certificate trust checks failed/,"Finding says certificate cannot be trusted."); $tests++;
is($f->{severity}, "NOT ok", "Severity should be NOT ok"); $tests++; is($f->{severity}, "CRITICAL", "Severity should be CRITICAL"); $tests++;
last; last;
} }
} }
@ -100,7 +100,7 @@ foreach my $f ( @$json ) {
if ( $f->{id} eq "chain_of_trust" ) { if ( $f->{id} eq "chain_of_trust" ) {
$found = 1; $found = 1;
like($f->{finding},qr/^All certificate trust checks failed.*incomplete/,"Finding says certificate cannot be trusted."); $tests++; like($f->{finding},qr/^All certificate trust checks failed.*incomplete/,"Finding says certificate cannot be trusted."); $tests++;
is($f->{severity}, "NOT ok", "Severity should be NOT ok"); $tests++; is($f->{severity}, "CRITICAL", "Severity should be CRITICAL"); $tests++;
last; last;
} }
} }
@ -118,7 +118,7 @@ is($found,1,"We had a finding for this in the JSON output"); $tests++;
# if ( $f->{id} eq "chain_of_trust" ) { # if ( $f->{id} eq "chain_of_trust" ) {
# $found = 1; # $found = 1;
# like($f->{finding},qr/^All certificate trust checks failed.*incomplete/,"Finding says certificate cannot be trusted."); $tests++; # like($f->{finding},qr/^All certificate trust checks failed.*incomplete/,"Finding says certificate cannot be trusted."); $tests++;
# is($f->{severity}, "NOT ok", "Severity should be NOT ok"); $tests++; # is($f->{severity}, "CRITICAL", "Severity should be CRITICAL"); $tests++;
# last; # last;
# } # }
#} #}
@ -132,4 +132,4 @@ sub json($) {
$file = `cat $file`; $file = `cat $file`;
unlink $file; unlink $file;
return from_json($file); return from_json($file);
} }

File diff suppressed because it is too large Load Diff