Git/testssl.sh
1
0
Fork 0
mirror of https://github.com/drwetter/testssl.sh.git synced 2025-01-10 18:50:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

Revert "small performance improvement for prepare_arrays() by replacing grep + awk by awk only"

Browse Source 
This reverts commit 3b1638f603.

I'm not sure what went wrong here, but these commands are not equivalent.

$ export hexc=0x00,0x05 && openssl ciphers -tls2 -V 'ALL:COMPLEMENTOFALL:@STRENGTH' | grep -w "$hexc" -
          0x00,0x05 - RC4-SHA                 SSLv3 Kx=RSA      Au=RSA Enc=RC4(128)  Mac=SHA1
$ export hexc=0x00,0x05 && openssl ciphers -tls2 -V 'ALL:COMPLEMENTOFALL:@STRENGTH' | grep -w "$hexc" - | awk '{ print $3 }'
RC4-SHA
$ export hexc=0x00,0x05 && openssl ciphers -tls2 -V 'ALL:COMPLEMENTOFALL:@STRENGTH' | awk '/\<'"$hexc"'\>/ { print $3 }'
$

The old command finds my RC4-SHA cipher, the new one does not.
This commit is contained in:
Steven Danneman 2017-07-19 13:47:24 -07:00
parent ad1dd01466
commit 2643afb1e5
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
testssl.sh
View File

@ -11417,7 +11417,7 @@ prepare_arrays() {
if [[ $OSSL_VER_MAJOR -lt 1 ]]; then
[[ ":${ossl_supported_tls}:" =~ ":${TLS_CIPHER_OSSL_NAME[i]}:" ]] && TLS_CIPHER_OSSL_SUPPORTED[i]=true
else
ossl_ciph="$(awk '/\<'"$hexc"'\>/ { print $3 }' <<< "$ossl_supported_tls")"
ossl_ciph="$(grep -w "$hexc" <<< "$ossl_supported_tls" | awk '{ print $3 }')"
if [[ -n "$ossl_ciph" ]]; then
TLS_CIPHER_OSSL_SUPPORTED[i]=true
[[ "$ossl_ciph" != "${TLS_CIPHER_OSSL_NAME[i]}" ]] && TLS_CIPHER_OSSL_NAME[i]="$ossl_ciph"