From 39132fe3d01442b7bfc8d25c7e1b1fd11ec2e523 Mon Sep 17 00:00:00 2001 From: Dirk Wetter Date: Fri, 11 Dec 2020 20:49:15 +0100 Subject: [PATCH] Fix order for -U and --ids-friendly Workaround for bug see #1717. In addition: Bring the test closer to a cleaner style, as the others Should --ids-firednly could be as well be removed when travis runs faster. --- t/33_isJSON_severitylevel_valid.t | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/t/33_isJSON_severitylevel_valid.t b/t/33_isJSON_severitylevel_valid.t index 234efc0..9f17de8 100755 --- a/t/33_isJSON_severitylevel_valid.t +++ b/t/33_isJSON_severitylevel_valid.t @@ -15,13 +15,18 @@ my ( $tests = 0; +my $prg="./testssl.sh"; +my $check2run = '-S -e --ids-friendly -U --severity LOW --color 0'; +my $uri = 'badssl.com'; printf "\n%s\n", "Doing severity level checks"; + +die "Unable to open $prg" unless -f $prg; unlink 'tmp.json'; #1 -pass(" .. running testssl.sh against badssl.com to create a JSON report with severity level equal greater than LOW (may take 2~3 minutes)"); $tests++; -$out = `./testssl.sh -S -e -U --ids-friendly --jsonfile tmp.json --severity LOW --color 0 badssl.com`; +pass(" .. running testssl.sh against $uri to create a JSON report with severity level >= LOW (may take 2~3 minutes)"); $tests++; +$out = `$prg $check2run --jsonfile tmp.json $uri`; $json = json('tmp.json'); unlink 'tmp.json'; $found = 0; @@ -35,8 +40,8 @@ foreach my $f ( @$json ) { is($found,0,"We should not have any finding with INFO level"); $tests++; #2 -pass(" .. running testssl.sh against badssl.com to create a JSON-PRETTY report with severity level equal greater than LOW (may take 2~3 minutes)"); $tests++; -$out = `./testssl.sh -S -e -U --ids-friendly --jsonfile-pretty tmp.json --severity LOW --color 0 badssl.com`; +pass(" .. running testssl.sh against $uri to create a JSON-PRETTY report with severity level >= LOW (may take 2~3 minutes)"); $tests++; +$out = `$prg $check2run --jsonfile-pretty tmp.json $uri`; $json_pretty = json('tmp.json'); unlink 'tmp.json'; $found = 0;