Merge pull request #1302 from drwetter/contributing

Add CONTRIBUTING.md, docker changes in Readme.md
This commit is contained in:
Dirk Wetter 2019-08-08 18:36:11 +02:00 committed by GitHub
commit 49fc218424
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 40 additions and 16 deletions

15
CONTRIBUTING.md Normal file
View File

@ -0,0 +1,15 @@
### Contributions / participation
is always welcome.
Note please that following is strongly requested:
* One PR per feature or bug fix or improvement.
* Document your PR properly, both in the PR and/or commit message and in the code.
* Please test your changes thoroughly as reliability is important for this project.
* Follow the length [coding guideline](https://github.com/drwetter/testssl.sh/wiki/Coding-Style).
If it's a new feature please consider writing a unit test for it. There's a directory ~/t/ which Travis runs automatically when anything is committed. You can use e.g. `20_baseline_ipv4_http.t` as a template. There's also [general documentation for Test::More](https://perldoc.perl.org/Test/More.html).

View File

@ -50,13 +50,25 @@ You can download testssl.sh by cloning this git repository:
git clone --depth 1 https://github.com/drwetter/testssl.sh.git git clone --depth 1 https://github.com/drwetter/testssl.sh.git
Or help yourself downloading the ZIP archive [https://github.com/drwetter/testssl.sh/archive/3.0.zip](https://github.com/drwetter/testssl.sh/archive/3.0.zip). Or help yourself downloading the ZIP archive [https://github.com/drwetter/testssl.sh/archive/3.0.zip](https://github.com/drwetter/testssl.sh/archive/3.0.zip). Just ``cd`` to the directory created (=INSTALLDIR) and run it off there.
``testssl.sh --help`` will give you some help upfront. More help: see doc directory with
man pages. Older sample runs are at [https://testssl.sh/](https://testssl.sh/).
#### Running a docker container from dockerhub ### Docker
Testssl.sh has minimal requirements. As stated you don't have to install or build anything. You can just run it from the pulled/cloned directory. Still if you don't want to pull the github repo to your directory of choice you can pull a container from dockerhub and run it:
```
docker run -ti drwetter/testssl.sh <your_cmd_line> docker run -ti drwetter/testssl.sh <your_cmd_line>
```
Or if you have cloned this repo you also can just ``cd`` to the INSTALLDIR and run
```
docker build .
```
followed by ``docker exec -ti <ID> <your_cmd_line>`` where ``ID`` is the identifier in the last line from the build command like
```
---> 889fa2f99933
Successfully built 889fa2f99933
```
### Status ### Status
@ -68,24 +80,21 @@ Support for 2.9.5 has been dropped.
### Documentation ### Documentation
* It is for reading. Please do so :-) at least before asking questions. * .. it is there for reading. Please do so :-) -- at least before asking questions. See man page in groff, html and markdown format in `~/doc/`.
* There's a man page in groff, html and markdown format in `~/doc/`.
* [https://testssl.sh/](https://testssl.sh/) will help to get you started. * [https://testssl.sh/](https://testssl.sh/) will help to get you started.
* Will Hunt provides a longer, good [description](https://www.4armed.com/blog/doing-your-own-ssl-tls-testing/) for the version 2.8, including useful background info. * Will Hunt provides a longer, good [description](https://www.4armed.com/blog/doing-your-own-ssl-tls-testing/) for the (older) version 2.8, including useful background info.
### Contributions ### Contributing
Contributions, feedback, bug reports are welcome! For contributions please Contributions are welcome! See [CONTRIBUTING.md](https://github.com/drwetter/testssl.sh/CONTRIBUTING.md) for details.
note: One patch per feature -- bug fix/improvement. Please test your
changes thoroughly as reliability is important for this project.
There's a [coding guideline](https://github.com/drwetter/testssl.sh/wiki/Coding-Style).
### Bug reports ### Bug reports
Please file bugs in the issue tracker @ github. Do not forget to provide detailed information, Also bug reports are important. It makes this project more robust.
see template. Details @ https://github.com/drwetter/testssl.sh/wiki/Bug-reporting. Nobody can read your
Please file bugs in the issue tracker @ github. Do not forget to provide detailed information, see template. Further details @
https://github.com/drwetter/testssl.sh/wiki/Bug-reporting. Nobody can read your
thoughts -- yet. And only agencies your screen ;-) thoughts -- yet. And only agencies your screen ;-)
You can also debug yourself, see [here](https://github.com/drwetter/testssl.sh/wiki/Findings-and-HowTo-Fix-them). You can also debug yourself, see [here](https://github.com/drwetter/testssl.sh/wiki/Findings-and-HowTo-Fix-them).