Make the flow finally(TM) work

.github/workflows/perl-quality.yml

@@ -20,22 +20,27 @@ jobs:
       - uses: shogo82148/actions-setup-perl@v1.43.1
         with:
           perl-version: '5.38'
+
       - name: Install dev modules
         run: cpanm --notest Perl::Critic Perl::Tidy CPAN::Audit
       - name: Install dev modules
         # add all perl modules from other modules tool, otherwise the next run fails
         run: cpanm --notest Data::Dumper IPC::Run3 JSON Test::More Text::Diff
-      - name: Syntax check all test files
+
+      - name: 'Syntax check #1 w Perl::Tidy'
+        run: |
+          perltidy -se t/*.t
+        #TODO: we should as well reformat with the t(i)dy files generated
+
+      - name: Syntax check all test files with perl itself
         run: |
           find t -name '*.t' -o -name '*.pm' | while read -r f; do
             perl -I t/lib -c "$f"
           done
-      - name: Perl::Critic
+
-        run: perlcritic --verbose '%f:%l:%e:%m\n' t/
+      - name: Use Perl::Critic for best practises
-      - name: perltidy (fail on diff)
+        run: perlcritic -4 t/*.t
-        run: |
+
-          perltidy -p t/
-          git diff --exit-code
       - name: Audit CPAN modules for known CVEs
         run: cpan-audit
 

.perlcritic

@@ -1,17 +0,0 @@
-# Perl::Critic policy overrides for the testssl.sh test suite (t/)
-#
-# see https://github.com/Perl-Critic/Perl-Critic
-
-# General setting: That would deliver way more
-# severity = 3
-
-
-# Test helpers commonly use subroutine prototypes (e.g. sub helper ($$));
-# harmless in test code.
-[Subroutines::ProhibitSubroutinePrototypes]
-severity = 4
-
-# Intentional octal file-permission literals (0400, 0100) in t/00_testssl_help.t.
-[ValuesAndExpressions::ProhibitLeadingZeros]
-severity = 4
-