From b8a9b9c6db7034419d64c1db2d2e15a9bca94e00 Mon Sep 17 00:00:00 2001 From: Dirk Date: Sat, 19 Jun 2021 09:20:48 +0200 Subject: [PATCH 1/4] Github actions modifications - define deny list of files when modified not to run GHA - specRitfy OS to be ubuntu-20.04 (is there a debian at all?) - only use perl 5.26 While researching I stumbled over mac.osx as an OS one can specify. If anybody knows whether this is really macosx (license?) please let me know. That would be a great addition for CI. (Couldn't find BSD yet...) See #1920 --- .github/workflows/test.yml | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index f30538d..2775db8 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -1,14 +1,24 @@ name: testssl.sh CI on: [push, pull_request] + paths-ignore: + - 'utils/**' + - 'docs/**' + - 'bin/**' + - '**.md' + - '**.pem' + - '**.pdf' + - '**.html' + - 'LICENSE' + - 'Dockerfile' jobs: build: runs-on: ${{ matrix.os }} strategy: matrix: - os: ['ubuntu-latest'] - perl: [ '5.30', '5.26' ] + os: ['ubuntu-20.04'] + perl: [ '5.26' ] name: Perl ${{ matrix.perl }} on ${{ matrix.os }} steps: - uses: actions/checkout@v2 From 5cd97ddcb9806e6f044dd6f7983fa55852d9aa17 Mon Sep 17 00:00:00 2001 From: Dirk Date: Sat, 19 Jun 2021 10:45:08 +0200 Subject: [PATCH 2/4] Correct YAML error in GHA + add macOS - yamllint to the rescue. Still shows an error though: 4:3 error syntax error: expected , but found '' (syntax) - added macos, see https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners --- .github/workflows/test.yml | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 2775db8..95283e5 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -1,24 +1,24 @@ name: testssl.sh CI on: [push, pull_request] - paths-ignore: - - 'utils/**' - - 'docs/**' - - 'bin/**' - - '**.md' - - '**.pem' - - '**.pdf' - - '**.html' - - 'LICENSE' - - 'Dockerfile' + paths-ignore: + - 'utils/**' + - 'docs/**' + - 'bin/**' + - '**.md' + - '**.pem' + - '**.pdf' + - '**.html' + - 'LICENSE' + - 'Dockerfile' jobs: build: runs-on: ${{ matrix.os }} strategy: matrix: - os: ['ubuntu-20.04'] - perl: [ '5.26' ] + os: ['ubuntu-20.04', 'macos-10.15'] + perl: ['5.26'] name: Perl ${{ matrix.perl }} on ${{ matrix.os }} steps: - uses: actions/checkout@v2 From 247d08882e4d3a7d7b80bbfb447b8bccdfe17624 Mon Sep 17 00:00:00 2001 From: Dirk Date: Sat, 19 Jun 2021 11:12:00 +0200 Subject: [PATCH 3/4] GHA: Fix push + PR see https://github.community/t/how-to-factor-paths-in-common-for-push-and-pull-request/115967/2 TL;DR: There is no way to specify the common paths for two events --- .github/workflows/test.yml | 33 ++++++++++++++++++++++----------- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 95283e5..6b53286 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -1,16 +1,27 @@ name: testssl.sh CI -on: [push, pull_request] - paths-ignore: - - 'utils/**' - - 'docs/**' - - 'bin/**' - - '**.md' - - '**.pem' - - '**.pdf' - - '**.html' - - 'LICENSE' - - 'Dockerfile' +on: + push: + paths-ignore: + - 'utils/**' + - 'docs/**' + - 'bin/**' + - '**.md' + - '**.pem' + - '**.pdf' + - '**.html' + - 'LICENSE' + - 'Dockerfile' + pull_request: + - 'utils/**' + - 'docs/**' + - 'bin/**' + - '**.md' + - '**.pem' + - '**.pdf' + - '**.html' + - 'LICENSE' + - 'Dockerfile' jobs: build: From 2af7860a3caab6e23915ca7016ce49d7c5e2e50a Mon Sep 17 00:00:00 2001 From: Dirk Date: Sat, 19 Jun 2021 11:17:52 +0200 Subject: [PATCH 4/4] Remove mac osx ... apt is probably not the right thing ;-) --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 6b53286..bbc4c8b 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -28,7 +28,7 @@ jobs: runs-on: ${{ matrix.os }} strategy: matrix: - os: ['ubuntu-20.04', 'macos-10.15'] + os: ['ubuntu-20.04'] perl: ['5.26'] name: Perl ${{ matrix.perl }} on ${{ matrix.os }} steps: