From a51a0a73a76571bfd0a072f180437d99ed78caab Mon Sep 17 00:00:00 2001 From: Dirk Date: Mon, 20 Jul 2020 11:43:52 +0200 Subject: [PATCH] Squash "No engine or GOST support via engine..." This is a legacy warning and seems only needed in a very few cases whereas in other few cases we don't issue such warnings. So to be consistent it's right to remove this message as it confuses users unnecessarily, It'll appear in debug mode though. See https://github.com/drwetter/testssl.sh/issues/1119#issuecomment-656271849 --- testssl.sh | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/testssl.sh b/testssl.sh index aee635a..cd32a8f 100755 --- a/testssl.sh +++ b/testssl.sh @@ -19208,8 +19208,7 @@ initialize_engine(){ export OPENSSL_CONF='' return 1 elif $OPENSSL engine gost -v 2>&1 | grep -Eq 'invalid command|no such engine'; then - outln - pr_warning "No engine or GOST support via engine with your $OPENSSL"; outln + [[ $DEBUG -ge 1 ]] && outln && pr_warning "No engine or GOST support via engine with your $OPENSSL"; outln fileout_insert_warning "engine_problem" "WARN" "No engine or GOST support via engine with your $OPENSSL" export OPENSSL_CONF='' return 1 @@ -19218,8 +19217,7 @@ initialize_engine(){ # to suppress the warning (confuses users), see #1119 # https://github.com/openssl/openssl/commit/b524b808a1d1ba204dbdcbb42de4e3bddb3472ac if ! grep -q 'using the .include directive' /etc/ssl/openssl.cnf; then - outln - pr_warning "No engine or GOST support via engine with your $OPENSSL"; outln + [[ $DEBUG -ge 1 ]] && outln && pr_warning "No engine or GOST support via engine with your $OPENSSL"; outln fi fileout_insert_warning "engine_problem" "WARN" "No engine or GOST support via engine with your $OPENSSL" # Avoid clashes of OpenSSL 1.1.1 config file with our openssl 1.0.2. This is for Debian 10