From b2ad9e3c15fbfad26ddaba6d4a57bd86438788f5 Mon Sep 17 00:00:00 2001 From: Dirk Date: Mon, 15 Oct 2018 09:33:12 +0200 Subject: [PATCH] Be more verbose what client is simulated Currently the client simulation is based on the handshake data from SSLlabs which is purely focussed on HTTP -- as SSLlabs does HTTP only. In #540 there was a PR addressing the fact that the data is not what is claims to be -- the handshake of Android 7 seems to be Chrome for Android and not Android itself. This PR tries at least to modify the headline for client simulations. --- testssl.sh | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/testssl.sh b/testssl.sh index 461b18a..f1907bb 100755 --- a/testssl.sh +++ b/testssl.sh @@ -4460,6 +4460,7 @@ run_client_simulation() { local options local -i ret=0 local jsonID="clientsimulation" + local client_service="" # source the external file . "$TESTSSL_INSTALL_DIR/etc/client-simulation.txt" 2>/dev/null @@ -4479,15 +4480,16 @@ run_client_simulation() { client_service="HTTP" else outln "Could not determine the protocol, only simulating generic clients." - client_service="undetermined" fi outln + pr_headline " Running client simulations " + [[ "$client_service" == HTTP ]] && pr_headline "($client_service) " if "$using_sockets"; then - pr_headlineln " Running client simulations via sockets " + pr_headlineln "via sockets " else - pr_headline " Running client simulations via openssl " - prln_warning " -- you shouldn't run this with \"--ssl-native\" as you will get false results" + pr_headline "via openssl " + prln_warning " -- pls note \"--ssl-native\" will return some false results" fileout "$jsonID" "WARN" "You shouldn't run this with \"--ssl-native\" as you will get false results" ret=1 fi