Git/testssl.sh
1
0
Fork 0
mirror of https://github.com/drwetter/testssl.sh.git synced 2025-11-03 23:35:26 +01:00
Code Issues Packages Projects Releases Wiki Activity

Label elliptic curve public keys as "EC"

Browse Source 
In the output created by certificate_info(), the "Server key size" line labels an elliptic curve key as "ECDSA." This commit changes the label to "EC." I believe this a more correct label since ECDSA is a signature algorithm, not a key type. Also, while unlikely, an elliptic curve key in a certificate may be used for ECDH (e.g, in TLS_ECDH_RSA_WITH_AES_128_CBC_SHA) rather than ECDSA.

Note that this does not impact the JSON or CSV output, since the corresponding fileout command already uses "$cert_keysize EC bits"
This commit is contained in:
David Cooper
2018-01-26 17:27:10 -05:00
committed by GitHub
parent c1d75f65ce
commit ee0b12bfca
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
testssl.sh
View File

@@ -6522,7 +6522,7 @@ certificate_info() {
case $cert_key_algo in case $cert_key_algo in
*RSA*|*rsa*) out "RSA ";; *RSA*|*rsa*) out "RSA ";;
*DSA*|*dsa*) out "DSA ";; *DSA*|*dsa*) out "DSA ";;
*ecdsa*|*ecPublicKey) out "ECDSA ";; *ecdsa*|*ecPublicKey) out "EC ";;
*GOST*|*gost*) out "GOST ";; *GOST*|*gost*) out "GOST ";;
*dh*|*DH*) out "DH " ;; *dh*|*DH*) out "DH " ;;
*) pr_fixme "don't know $cert_key_algo " ;; *) pr_fixme "don't know $cert_key_algo " ;;