Commit Graph

4007 Commits

Author SHA1 Message Date
Dirk 28d9bc483d Fix redundant message (BREACH) when client certificate required
same as #1916.

Fixes #1915
2021-06-19 15:27:03 +02:00
Dirk Wetter 9f0d0c0062
Merge pull request #1921 from drwetter/gha_denylist
Github actions modifications
2021-06-19 12:30:00 +02:00
Dirk 2af7860a3c Remove mac osx
... apt is probably not the right thing ;-)
2021-06-19 11:17:52 +02:00
Dirk 247d08882e GHA: Fix push + PR
see https://github.community/t/how-to-factor-paths-in-common-for-push-and-pull-request/115967/2

TL;DR:  There is no way to specify the common paths for two events
2021-06-19 11:12:00 +02:00
Dirk 5cd97ddcb9 Correct YAML error in GHA + add macOS
- yamllint to the rescue. Still shows an error though:
  4:3       error    syntax error: expected <block end>, but found '<block mapping start>' (syntax)

- added macos, see https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners
2021-06-19 10:45:08 +02:00
Dirk b8a9b9c6db Github actions modifications
- define deny list of files when modified not to run GHA
- specRitfy OS to be ubuntu-20.04 (is there a debian at all?)
- only use perl 5.26

While researching I stumbled over mac.osx as an OS one can specify. If anybody
knows whether this is really macosx (license?) please let me know. That
would be a great addition for CI. (Couldn't find BSD yet...)

See #1920
2021-06-19 09:20:48 +02:00
Dirk Wetter 2d3bd724fc
Merge pull request #1912 from PeterDaveHello/MakeShellScriptShebangConsistent
Make Shell Scripts' Shebang more consistent
2021-06-18 08:59:22 +02:00
Dirk Wetter cb844557f8
Merge pull request #1913 from PeterDaveHello/CorrectExitUsage
Correct `exit` using, the exit status should be 0~255
2021-06-18 08:55:22 +02:00
Dirk Wetter 35c43719dd
Merge pull request #1919 from drwetter/rm_travisCIhook
Remove travis CI hook
2021-06-18 08:47:52 +02:00
Dirk Wetter f91c0251be Rmeove travis CI hook
.. as we're using GHA now
2021-06-18 08:44:36 +02:00
Peter Dave Hello ce634f7deb Correct `exit` using, the exit status should be 0~255
According to the POSIX Programmer's Manual, the exit status specified by
the unsigned decimal integer. If n is specified, but its value is not
between 0 and 255 inclusively, the exit status is undefined.

By cross reference the usage between different scripts in this project,
it looks like we could simply remove the `-` before the number.
2021-06-15 16:04:23 +08:00
Peter Dave Hello 4de952a4dd Make Shell Scripts' Shebang more consistent
Consider most of the scripts use bash in the project, should maybe just
use it, instead of /bin/sh in all the scripts.
2021-06-15 15:52:49 +08:00
Dirk Wetter 17b172229d
Merge pull request #1909 from mikelolasagasti/gha
Add GitHub Actions testing
2021-06-07 09:16:31 +02:00
Mikel Olasagasti Uranga ebcd3105c8 Add GitHub Actions testing 2021-06-06 21:06:58 +02:00
Dirk Wetter 7da45a81f8
Merge pull request #1905 from drwetter/tz_fix+
Display time as suggested in utc (3.1dev)
2021-06-03 20:19:29 +02:00
Dirk Wetter e1be4eabd2 Display time as suggested in utc (3.1dev)
See #1895
2021-06-03 19:24:50 +02:00
Dirk Wetter 0da8ce02cd
Merge pull request #1904 from PeterDaveHello/AddBasicEditorConfig
Add a basic .editorconfig into project
2021-06-01 14:26:47 +02:00
Dirk Wetter 83909dec0c
Merge pull request #1903 from PeterDaveHello/MakeVimModelineConsistent
Add missing vim modeline config in sh & perl files
2021-06-01 11:20:33 +02:00
Peter Dave Hello f447ca466b Add a basic .editorconfig into project, close #1901 2021-06-01 14:51:06 +08:00
Peter Dave Hello cbae32e5a4 Add missing vim modeline config in sh & perl files, cc #1901 2021-06-01 14:40:24 +08:00
Dirk Wetter 737ea1e7e5
Merge pull request #1902 from PeterDaveHello/MakeVimModelineConsistent
Make vim modeline config consistent
2021-06-01 08:34:23 +02:00
Peter Dave Hello 9e61b8ba13 Make vim modeline config consistent, cc #1901 2021-06-01 14:31:31 +08:00
Dirk Wetter 1d306db062
Merge pull request #1900 from PeterDaveHello/ShebangConsistency
Make Shell Scripts' Shebang more consistent and portable
2021-05-31 10:17:47 +02:00
Dirk Wetter 893bb98a61
Merge pull request #1898 from PeterDaveHello/FixIndentation
Fix indentation in testssl.sh
2021-05-31 10:16:45 +02:00
Peter Dave Hello 50ee914ee4 Make Shell Scripts' Shebang more consistent and portable 2021-05-31 15:27:37 +08:00
Dirk Wetter 4d62f08308
Merge pull request #1899 from PeterDaveHello/IsGitHub
Correct "GitHub" case as it should be
2021-05-29 21:24:58 +02:00
Peter Dave Hello 8d42528ec6 Correct "GitHub" case as it should be 2021-05-30 01:19:58 +08:00
Peter Dave Hello 413f7ce9a4 Fix indentation in testssl.sh 2021-05-30 01:12:15 +08:00
Dirk Wetter d41ea6c814
Merge pull request #1896 from PeterDaveHello/FixCompressionDetection
Fix compression detection variable syntax in run_breach()
2021-05-28 22:29:11 +02:00
Peter Dave Hello 1b4b9e3262 Fix compression detection variable syntax in run_breach() 2021-05-28 23:43:43 +08:00
Dirk Wetter 1387b4ccb4
Merge pull request #1893 from drwetter/drwetter-patch-1
Update feature_request.md
2021-05-16 15:24:23 +02:00
Dirk Wetter 3fea4e01e1
Update feature_request.md 2021-05-16 15:24:06 +02:00
Dirk Wetter 46ad8801de
Merge pull request #1892 from drwetter/drwetter-patch-1
Update bug_report.md
2021-05-16 15:07:19 +02:00
Dirk Wetter 188003ea97
Update bug_report.md 2021-05-16 15:07:08 +02:00
Dirk Wetter 15ace79a4c
Merge pull request #1722 from vitaliytv/patch-1
upd alpine to 3.12
2021-05-15 12:27:41 +02:00
Dirk Wetter 325e7380b9
Merge pull request #1888 from dcooper16/send_to_stderr
Print errors to stderr
2021-05-15 12:22:34 +02:00
Dirk Wetter e4807a7c9a
Merge pull request #1890 from dcooper16/specify_err_code
Specify an error code in all calls to fatal()
2021-05-13 18:46:05 +02:00
David Cooper 265c85a44f Specify an error code in all calls to fatal()
This commit fix a few places in which calls to fatal() do not specify an error code.
2021-05-13 11:32:56 -04:00
David Cooper 0552fdadb8 Print errors to stderr
In parse_cmd_line() error messages are usually printed to stderr, but in three places the messages are printed to stdout. This commit modifies those three lines so that they also print to stderr.

The commit also replaces a call to a non-existant function, tmln_magenta_term, with a call to tmln_magenta.
2021-05-13 11:10:01 -04:00
Dirk Wetter 17ad3d70a4
Merge pull request #1882 from drwetter/epoch_180hsts_1879
Fix "off by one" error in HSTS
2021-05-10 12:12:39 +02:00
Dirk Wetter a6f8aa61de Fix travis
Respect changed HSTS epoch time of 180 days.

(DROWN output is changed too as the certificated changed but doesn't matter
as the travis check filters that)
2021-05-10 11:28:25 +02:00
Dirk Wetter 2c3589742b
Merge pull request #1884 from definity/3.1dev
fixed minor bug with json output for TLS1.1
2021-05-09 10:56:56 +02:00
Chad Brigance 6b9d8bbc51 fixed minor bug with json output for TLS1.1 2021-05-08 19:24:56 +00:00
Dirk Wetter 9121c7a3c9 Fix "off by one" error in HSTS
There was by mistake a 179 days threshold and also the error message
was wrong when HSTS was exactly set to 179 days.

This commit sets it to 180 days and corrects the error messages on
both screen and JSON.
2021-05-08 14:45:38 +02:00
Dirk Wetter 37a6b905a5
Merge pull request #1868 from dcooper16/improve_ossl30_support
Improve compatibility with OpenSSL 3.0
2021-04-08 15:00:28 +02:00
David Cooper 944eb1bcd9 Improve compatibility with OpenSSL 3.0
This commit addresses a few issued related to the use of testssl.sh with OpenSSL 3.0.0-alpha14.

First, when pkey is used to print a DH key that uses an unknown group, OpenSSL 3.0.0-alpha14 labels the prime and generator using "P:" and "G:" rather than "prime:" and "generator:". (In PR #1586 it was noted that OpenSSL 3.0.0-alpha1 used "prime P:" and "generator G:". The x509 command in OpenSSL 3.0.0-alpha14 still uses "prime P:" and "generator G:" when printing a DH public key in a certificate, but the pkey command just uses "P:" and "G:").

Second, when the pkey command is used to print a DH key that uses certain common primes (e.g., groups from RFC 3526 or RFC 7919), OpenSSL 3.0.0-alpha14 simply prints "GROUP: " followed by a short name for the group rather than printing the value of the prime and generator.

Finally, the "-text" option no longer works if the input is a public key. Fortunately, the "-text_pub" option provides the expected results with all versions of OpenSSL and LibreSSL.
2021-04-07 13:28:34 -04:00
Dirk Wetter ac39aa5832
Merge pull request #1865 from drwetter/fix1860_svSE_etc_charset
Ensure certain regex patterns work as expected and aren't localized
2021-04-04 17:46:50 +02:00
Dirk 30bafe6d4f Ensure certain regex patterns work as expected and aren't localized
see #1860 .

This PR is trying to address an issue where probably newer bash versions
is treated differently as in other locales, W is just a variant of V
see also e.g.

https://collation-charts.org/opensolaris/opensolaris.2008.05.sv_SE.UTF-8.html
https://www.sqlservercentral.com/forums/topic/order-by-name-not-works#post-1644177
2021-04-04 11:55:29 +02:00
Dirk Wetter 1569bded44
Merge pull request #1864 from drwetter/rhs_quotes_fix
Fix redundant quotes at RHS of ==
2021-04-02 18:13:57 +02:00
Dirk 2101425c59 Fix redundant quotes at RHS of ==
While looking at #1860 there were two instances where
the right hand side of expressions in a double square
bracket had quotes.
2021-04-02 17:01:36 +02:00