mirror of
https://gitea.com/gitea/tea.git
synced 2026-10-26 19:11:25 +01:00
fix(pr): review decision ignores comment reviews, paged review list, pending review comments hidden, team request names (follow gh)
Signed-off-by: bircni <bircni@icloud.com>
This commit is contained in:
19 files changed
+258
-50
No files matched your search
@@ -54,6 +54,30 @@ func TestReviewRequestPartialFailureStopsFurtherEdits(t *testing.T) {
|
||||
require.Equal(t, 2, mutations)
|
||||
}
|
||||
|
||||
func TestReviewerTeamCheckSkippedWhenTeamListingIsForbidden(t *testing.T) {
|
||||
var posted bool
|
||||
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
switch {
|
||||
case r.URL.Path == "/api/v1/orgs/owner":
|
||||
_, _ = w.Write([]byte(`{"id":1}`))
|
||||
case r.URL.Path == "/api/v1/orgs/owner/teams":
|
||||
w.WriteHeader(http.StatusForbidden)
|
||||
_, _ = w.Write([]byte(`{"message":"Must be an organization member"}`))
|
||||
case r.Method == http.MethodPost && r.URL.Path == "/api/v1/repos/owner/repo/pulls/1/requested_reviewers":
|
||||
posted = true
|
||||
w.WriteHeader(http.StatusCreated)
|
||||
_, _ = w.Write([]byte(`[]`))
|
||||
default:
|
||||
_, _ = w.Write([]byte(`{"number":1}`))
|
||||
}
|
||||
}))
|
||||
defer server.Close()
|
||||
changes := ReviewRequestChanges{Add: ReviewRequestInput{Teams: []string{"devs"}}}
|
||||
_, err := (Reviews{Client: transport.New(server.URL, "", false), Repository: "owner/repo"}).ChangeRequests(context.Background(), 1, changes)
|
||||
require.NoError(t, err)
|
||||
require.True(t, posted, "the server decides whether the team exists")
|
||||
}
|
||||
|
||||
func TestUnknownReviewerTeamRejectsBeforeUserRemoval(t *testing.T) {
|
||||
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
require.Equal(t, http.MethodGet, r.Method)
|
||||
|
||||
Reference in new issue
Block a user