mirror of
https://gitea.com/gitea/tea.git
synced 2026-05-02 21:13:50 +02:00
## What this PR does
`tea issues list --assignee USERNAME` currently returns every issue regardless of the assignee value — even nonexistent users return a full unfiltered list. Discovered against **tea v0.14.0** (with go-sdk v0.24.1) and reproduced on current `master` (commit `dd81b33`). This PR fixes that.
## Root cause
Two distinct bugs on the same flag, both in `cmd/issues/list.go`:
1. **Per-repo path** (`tea issues list --repo OWNER/REPO --assignee USER`): the code reads `ctx.String("assigned-to")` for `AssignedBy`, but the flag is defined as `--assignee` in `cmd/flags/issue_pr.go:66`. The lookup always returns `""`, so the SDK omits the `assigned_by` query parameter and the API returns everything.
2. **Global path** (`tea issues list --assignee USER`, no `--repo`): this hits `/repos/issues/search`, which silently ignores `assigned_by`. Even after fix #1 the no-repo form would still return unfiltered results. Verified directly:
- `GET /repos/issues/search?assigned_by=USER&owner=ORG&state=open` → all open issues
- `GET /repos/issues/search?assigned=true&owner=ORG&state=open` → only the issues assigned to the authenticated user
The endpoint only supports `assigned=true` (boolean self-filter), not arbitrary-user filtering, and `ListIssueOption` doesn't expose that field. Rather than misleading the caller, the no-repo path now returns a clear error.
## Changes
Both changes are in `cmd/issues/list.go`:
1. Read `ctx.String("assignee")` instead of the non-existent flag name `"assigned-to"` (lines 80 and 97).
2. In the no-`--repo` branch, return `errors.New("--assignee requires --repo (...)")` when the flag is set.
`cmd/pulls/list.go` does not expose an assignee filter, so it's unaffected. The `--author` mapping (`CreatedBy ← ctx.String("author")`) was already correct and is the model the fix follows.
## Manual verification
Tested against a local Gitea instance with three open issues (only one assigned to the test user):
| Command | Before | After |
|---|---|---|
| `tea issues list --repo X --assignee me` | all 3 | only the 1 assigned ✓ |
| `tea issues list --repo X --assignee nonexistent` | all 3 | `Error: not found` ✓ |
| `tea issues list --repo X --author me` | only the 1 (control) | unchanged ✓ |
| `tea issues list --assignee me` (no `--repo`) | all 3 (silent) | clear error ✓ |
| `tea issues list` (no flags) | all 3 | unchanged ✓ |
---------
Co-authored-by: claude_1 <claude_1@bot.gqx.lol>
Reviewed-on: https://gitea.com/gitea/tea/pulls/971
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: Oleksii Zaremskyi <grossqx@gmail.com>
Co-committed-by: Oleksii Zaremskyi <grossqx@gmail.com>
120 lines
3.0 KiB
Go
120 lines
3.0 KiB
Go
// Copyright 2020 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package issues
|
|
|
|
import (
|
|
stdctx "context"
|
|
"errors"
|
|
"time"
|
|
|
|
"code.gitea.io/tea/cmd/flags"
|
|
"code.gitea.io/tea/modules/context"
|
|
"code.gitea.io/tea/modules/print"
|
|
|
|
"code.gitea.io/sdk/gitea"
|
|
"github.com/araddon/dateparse"
|
|
"github.com/urfave/cli/v3"
|
|
)
|
|
|
|
var issueFieldsFlag = flags.FieldsFlag(print.IssueFields, []string{
|
|
"index", "title", "state", "author", "milestone", "labels", "owner", "repo",
|
|
})
|
|
|
|
// CmdIssuesList represents a sub command of issues to list issues
|
|
var CmdIssuesList = cli.Command{
|
|
Name: "list",
|
|
Aliases: []string{"ls"},
|
|
Usage: "List issues of the repository",
|
|
Description: `List issues of the repository`,
|
|
ArgsUsage: " ", // command does not accept arguments
|
|
Action: RunIssuesList,
|
|
Flags: append([]cli.Flag{issueFieldsFlag}, flags.IssueListingFlags...),
|
|
}
|
|
|
|
// RunIssuesList list issues
|
|
func RunIssuesList(_ stdctx.Context, cmd *cli.Command) error {
|
|
ctx, err := context.InitCommand(cmd)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
state, err := flags.ParseState(ctx.String("state"))
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
kind, err := flags.ParseIssueKind(ctx.String("kind"), gitea.IssueTypeIssue)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
var from, until time.Time
|
|
if ctx.IsSet("from") {
|
|
from, err = dateparse.ParseLocal(ctx.String("from"))
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
if ctx.IsSet("until") {
|
|
until, err = dateparse.ParseLocal(ctx.String("until"))
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
owner := ctx.Owner
|
|
if ctx.IsSet("owner") {
|
|
owner = ctx.String("owner")
|
|
}
|
|
|
|
// ignore error, as we don't do any input validation on these flags
|
|
labels, _ := flags.LabelFilterFlag.GetValues(cmd)
|
|
milestones, _ := flags.MilestoneFilterFlag.GetValues(cmd)
|
|
var issues []*gitea.Issue
|
|
if ctx.Repo != "" {
|
|
issues, _, err = ctx.Login.Client().ListRepoIssues(owner, ctx.Repo, gitea.ListIssueOption{
|
|
ListOptions: flags.GetListOptions(cmd),
|
|
State: state,
|
|
Type: kind,
|
|
KeyWord: ctx.String("keyword"),
|
|
CreatedBy: ctx.String("author"),
|
|
AssignedBy: ctx.String("assignee"),
|
|
MentionedBy: ctx.String("mentions"),
|
|
Labels: labels,
|
|
Milestones: milestones,
|
|
Since: from,
|
|
Before: until,
|
|
})
|
|
if err != nil {
|
|
return err
|
|
}
|
|
} else {
|
|
if ctx.IsSet("assignee") {
|
|
return errors.New("--assignee requires --repo (global issue search does not support assignee filter)")
|
|
}
|
|
issues, _, err = ctx.Login.Client().ListIssues(gitea.ListIssueOption{
|
|
ListOptions: flags.GetListOptions(cmd),
|
|
State: state,
|
|
Type: kind,
|
|
KeyWord: ctx.String("keyword"),
|
|
CreatedBy: ctx.String("author"),
|
|
MentionedBy: ctx.String("mentions"),
|
|
Labels: labels,
|
|
Milestones: milestones,
|
|
Since: from,
|
|
Before: until,
|
|
Owner: owner,
|
|
})
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
fields, err := issueFieldsFlag.GetValues(cmd)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
return print.IssuesPullsList(issues, ctx.Output, fields)
|
|
}
|