mirror of
https://gitea.com/gitea/tea.git
synced 2026-10-26 19:11:25 +01:00
bircni
c5f674111a
Reverts #1126, #1125, #1124, #1123 and #1122. `go.mod` keeps the Go 1.26 line with toolchain `go1.26.9` (instead of the original `go1.26.6`) so the security fix from #1131 isn't lost. reopens #69 reopens #141 reopens #162 reopens #172 reopens #197 reopens #232 reopens #240 reopens #246 reopens #323 reopens #325 reopens #326 reopens #328 reopens #344 reopens #351 reopens #373 reopens #403 reopens #406 reopens #417 reopens #430 reopens #457 reopens #480 reopens #482 reopens #489 reopens #490 reopens #498 reopens #500 reopens #504 reopens #510 reopens #516 reopens #523 reopens #556 reopens #560 reopens #569 reopens #571 reopens #602 reopens #632 reopens #633 reopens #643 reopens #666 reopens #670 reopens #672 reopens #677 reopens #683 reopens #697 reopens #726 reopens #737 reopens #770 reopens #779 reopens #804 reopens #817 reopens #831 reopens #833 reopens #834 reopens #908 reopens #966 reopens #1023 reopens #1029 reopens #1032 reopens #1050 reopens #1052 reopens #1069 reopens #1073 reopens #1087 reopens #1091 reopens #1094 reopens #1110 reopens #1115 reopens #1116 reopens #1118 Reviewed-on: https://gitea.com/gitea/tea/pulls/1146 Reviewed-by: TheFox0x7 <95654+thefox0x7@noreply.gitea.com>
65 lines
2.2 KiB
Go
65 lines
2.2 KiB
Go
// Copyright 2026 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package theme
|
|
|
|
import (
|
|
"os/exec"
|
|
"slices"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
// compatPkg detects the terminal background from package-level vars, so importing
|
|
// it anywhere makes tea query the terminal before main() runs. On Windows that
|
|
// query can block forever when stdio is redirected, which hung every tea command,
|
|
// including tea --version.
|
|
//
|
|
// lipgloss.LightDark covers what we need without the package-level detection, so
|
|
// nothing in tea should depend on compat again.
|
|
const compatPkg = "charm.land/lipgloss/v2/compat"
|
|
|
|
func TestBinaryDoesNotImportLipglossCompat(t *testing.T) {
|
|
if _, err := exec.LookPath("go"); err != nil {
|
|
t.Skip("go is not on PATH")
|
|
}
|
|
|
|
out, err := exec.Command("go", "list", "-deps", "gitea.dev/tea").Output()
|
|
require.NoError(t, err, "go list -deps")
|
|
|
|
imported := slices.Contains(strings.Fields(string(out)), compatPkg)
|
|
assert.False(t, imported,
|
|
"%s is back in tea's import graph. It detects the terminal background from "+
|
|
"package-level vars, so tea queries the terminal before main() runs, and on "+
|
|
"Windows that hangs at start-up when stdio is redirected.", compatPkg)
|
|
}
|
|
|
|
// Under go test neither stdin nor stdout is a terminal, so HasDarkBackground must
|
|
// take the default and return, rather than querying and waiting for an answer.
|
|
func TestHasDarkBackgroundDoesNotBlockWithoutTTY(t *testing.T) {
|
|
done := make(chan bool, 1)
|
|
go func() {
|
|
done <- HasDarkBackground()
|
|
}()
|
|
|
|
select {
|
|
case got := <-done:
|
|
assert.Equal(t, defaultDarkBackground, got)
|
|
case <-time.After(5 * time.Second):
|
|
t.Fatal("HasDarkBackground blocked when stdio is not a terminal")
|
|
}
|
|
}
|
|
|
|
// The title color has to come from the isDark we are handed. It used to come from
|
|
// a process-wide value that compat detected at init, which ignored this argument.
|
|
func TestThemeHonorsIsDark(t *testing.T) {
|
|
dark := GetTheme().Theme(true).Focused.Title.GetForeground()
|
|
light := GetTheme().Theme(false).Focused.Title.GetForeground()
|
|
|
|
assert.NotEqual(t, dark, light, "Theme ignored isDark when picking the title color")
|
|
}
|