mirror of
https://gitea.com/gitea/tea.git
synced 2026-06-05 18:58:43 +02:00
5fa24b9a65
Closes #979. An alternative to the approach in #980 — this one is purely client-side title-mangling, no SDK changes needed. Gitea already treats any PR with a `WIP:` or `[WIP]` title prefix (case-insensitive) as a draft. This patch wires three flags around that behavior: - `tea pulls create --draft` — prepend `WIP: ` to the title at creation time - `tea pulls edit --draft <idx>` — add `WIP: ` to an existing PR's title - `tea pulls edit --ready <idx>` — strip any recognized draft prefix All three are idempotent. `--draft` and `--ready` on edit are mutually exclusive. If the user also passes `--title` on edit, the toggle applies to the supplied title; otherwise the current title is fetched from the server first. Why this approach over a server-payload-based one: Gitea's draft state is *defined* as the title-prefix convention (see the Gitea source for `HasWIPPrefix`). Modeling it server-side would either duplicate or fight that. A small string helper covers it without needing the SDK to add a `Draft` field. Verified against `gitea.com` (1.26.0+dev) with a throwaway repo: - create with `--draft` → server reports `draft: true` ✓ - `edit --ready` strips → `draft: false` ✓ - `edit --draft` adds back → `draft: true` ✓ - second `edit --draft` is idempotent ✓ - `edit --draft --ready` errors ✓ Unit tests for the prefix detection live in `modules/utils/draft_test.go`. --- This patch was authored interactively with an AI assistant, driven and reviewed by a human (Tyler / @dinsmoor) every step. Reproduction, design decisions, and the choice not to follow #980's payload approach were mine — happy to discuss any of it. *pull request created by Tyler's lovingly wrangled demon machine <3* --------- Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Reviewed-on: https://gitea.com/gitea/tea/pulls/1008 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Tyler <tyler@dinsmoor.us> Co-committed-by: Tyler <tyler@dinsmoor.us>
120 lines
3.0 KiB
Go
120 lines
3.0 KiB
Go
// Copyright 2020 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package pulls
|
|
|
|
import (
|
|
stdctx "context"
|
|
|
|
gitea "gitea.dev/sdk"
|
|
"github.com/urfave/cli/v3"
|
|
|
|
"gitea.dev/tea/cmd/flags"
|
|
"gitea.dev/tea/modules/context"
|
|
"gitea.dev/tea/modules/interact"
|
|
"gitea.dev/tea/modules/task"
|
|
"gitea.dev/tea/modules/utils"
|
|
)
|
|
|
|
// CmdPullsCreate creates a pull request
|
|
var CmdPullsCreate = cli.Command{
|
|
Name: "create",
|
|
Aliases: []string{"c"},
|
|
Usage: "Create a pull-request",
|
|
Description: "Create a pull-request in the current repo",
|
|
Action: runPullsCreate,
|
|
Flags: append([]cli.Flag{
|
|
&cli.StringFlag{
|
|
Name: "head",
|
|
Usage: "Branch name of the PR source (default is current one). To specify a different head repo, use <user>:<branch>",
|
|
},
|
|
&cli.StringFlag{
|
|
Name: "base",
|
|
Aliases: []string{"b"},
|
|
Usage: "Branch name of the PR target (default is repos default branch)",
|
|
},
|
|
&cli.BoolFlag{
|
|
Name: "allow-maintainer-edits",
|
|
Aliases: []string{"edits"},
|
|
Usage: "Enable maintainers to push to the base branch of created pull",
|
|
Value: true,
|
|
},
|
|
&cli.BoolFlag{
|
|
Name: "agit",
|
|
Usage: "Create an agit flow pull request",
|
|
},
|
|
&cli.StringFlag{
|
|
Name: "topic",
|
|
Usage: "Topic name for agit flow pull request",
|
|
},
|
|
&cli.BoolFlag{
|
|
Name: "draft",
|
|
Usage: "Create as a draft (prepends \"WIP: \" to the title; Gitea treats WIP-prefixed PRs as drafts)",
|
|
},
|
|
}, flags.IssuePRCreateFlags...),
|
|
}
|
|
|
|
func runPullsCreate(requestCtx stdctx.Context, cmd *cli.Command) error {
|
|
ctx, err := context.InitCommand(cmd)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
// Interactive mode and head-branch defaulting both need a local repo.
|
|
// When --head is given explicitly the user can target a cross-fork PR
|
|
// from outside a working tree (e.g. with --repo <owner>/<repo>);
|
|
// task.CreatePull only consults ctx.LocalRepo when head is empty.
|
|
needsLocalRepo := ctx.IsInteractiveMode() || len(ctx.String("head")) == 0
|
|
requirement := context.CtxRequirement{RemoteRepo: true}
|
|
if needsLocalRepo {
|
|
requirement.LocalRepo = true
|
|
}
|
|
if err := ctx.Ensure(requirement); err != nil {
|
|
return err
|
|
}
|
|
|
|
// no args -> interactive mode
|
|
if ctx.IsInteractiveMode() {
|
|
if err := interact.CreatePull(requestCtx, ctx); err != nil && !interact.IsQuitting(err) {
|
|
return err
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// else use args to create PR
|
|
opts, err := flags.GetIssuePRCreateFlags(requestCtx, ctx)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if ctx.Bool("draft") {
|
|
opts.Title = utils.AddDraftPrefix(opts.Title)
|
|
}
|
|
|
|
if ctx.Bool("agit") {
|
|
return task.CreateAgitFlowPull(
|
|
requestCtx,
|
|
ctx,
|
|
ctx.String("remote"),
|
|
ctx.String("head"),
|
|
ctx.String("base"),
|
|
ctx.String("topic"),
|
|
opts,
|
|
interact.PromptPassword,
|
|
)
|
|
}
|
|
|
|
var allowMaintainerEdits *bool
|
|
if ctx.IsSet("allow-maintainer-edits") {
|
|
allowMaintainerEdits = gitea.OptionalBool(ctx.Bool("allow-maintainer-edits"))
|
|
}
|
|
|
|
return task.CreatePull(
|
|
requestCtx,
|
|
ctx,
|
|
ctx.String("base"),
|
|
ctx.String("head"),
|
|
allowMaintainerEdits,
|
|
opts,
|
|
)
|
|
}
|