Files
gitea-tea/internal/app/teams.go
T
bircni f02245449b feat!: rebuild tea on Cobra with explicit noun/verb commands (#1126)
- **switch tea to the Cobra command tree:** `internal/app` wires the packages from parts 1–4 into explicit noun/verb commands with `--repo`, `--json` / `--jq`, `--sudo` and `--debug`; `main.go` points at it. Build, release and docs tooling (`tools/cli-docs`, Makefile, goreleaser, snap, CI) and README / CONTRIBUTING are updated.
- **remove the urfave/cli command tree:** deletes `cmd/`, `modules/`, the old integration tests, contrib completion scripts and the generated `docs/CLI.md`, and drops their dependencies. This commit only deletes.

## Breaking changes

This is a breaking release. It requires Gitea 28 or newer; configuration moves to separate `config.yml` and `hosts.yml` files and requires fresh authentication, and command names, aliases, flags and output formats change. `docs/migration-1.0.md` maps every old command, flag and environment variable to its replacement.

## Issues

fixes #1118
fixes #1116
fixes #1115
fixes #1094
fixes #1091
fixes #1073
fixes #1052
fixes #1032
fixes #1023
fixes #966
fixes #908
fixes #833
fixes #831
fixes #817
fixes #804
fixes #779
fixes #770
fixes #737
fixes #697
fixes #726
fixes #677
fixes #672
fixes #633
fixes #632
fixes #560
fixes #556
fixes #523
fixes #516
fixes #510
fixes #504
fixes #500
fixes #482
fixes #406
fixes #403
fixes #373
fixes #351
fixes #344
fixes #326
fixes #325
fixes #323
fixes #246
fixes #240
fixes #232
fixes #197
fixes #172
fixes #141
fixes #69
fixes #1110
fixes #569
fixes #480
fixes #666
fixes #670
fixes #457
fixes #643
fixes #498
fixes #490
fixes #1069
fixes #834
fixes #602
fixes #328
fixes #417
fixes #571
fixes #1029
fixes #489
fixes #1050
fixes #162
fixes #430
fixes #1087
fixes #683

Reviewed-on: https://gitea.com/gitea/tea/pulls/1126
Reviewed-by: TheFox0x7 <95654+thefox0x7@noreply.gitea.com>
2026-10-11 17:23:06 +00:00

220 lines
7.5 KiB
Go

// Copyright 2026 The Gitea Authors. All rights reserved.
// SPDX-License-Identifier: MIT
package app
import (
"errors"
"strconv"
"strings"
"gitea.dev/tea/internal/clierr"
"gitea.dev/tea/internal/services"
"gitea.dev/tea/internal/terminal"
"github.com/spf13/cobra"
)
var teamUnitNames = map[string]bool{"repo.code": true, "repo.issues": true, "repo.pulls": true, "repo.ext_issues": true, "repo.wiki": true, "repo.ext_wiki": true, "repo.releases": true, "repo.projects": true, "repo.packages": true, "repo.actions": true}
func (a *application) teamCommand() *cobra.Command {
group := &cobra.Command{Use: "team", Short: "Manage organization teams and access"}
var limit, page int
list := &cobra.Command{Use: "list <org>", Short: "List organization teams", Args: argsExact(1), RunE: func(cmd *cobra.Command, args []string) error {
target, err := a.resolve(cmd.Context(), false)
if err != nil {
return err
}
items, err := (services.Teams{Client: target.client}).List(cmd.Context(), args[0], limit, page)
if err != nil {
return err
}
return writeList(a, cmd, items, teamRow)
}}
pageFlags(list, &limit, &page)
group.AddCommand(list)
for _, verb := range []string{"view", "create", "edit", "delete"} {
var name, description, permission string
var createRepo, allRepos bool
var units map[string]string
command := &cobra.Command{Use: verb + " <id>", Short: titleCase(verb) + " an organization team", Args: argsExact(1)}
switch verb {
case "create":
command.Use = "create <org>"
case "delete":
command.Annotations = textOutput("team deletion does not return a resource")
}
if verb == "create" || verb == "edit" {
command.Flags().StringVar(&name, "name", "", "Team name")
command.Flags().StringVar(&description, "description", "", "Team description")
command.Flags().StringVar(&permission, "permission", "read", "Default access: read, write, admin")
command.Flags().StringToStringVar(&units, "unit", nil, "Unit permissions, for example repo.code=write,repo.issues=read (replaces unit policy)")
command.Flags().BoolVar(&createRepo, "can-create-repo", false, "Allow creating organization repositories")
command.Flags().BoolVar(&allRepos, "all-repositories", false, "Access every organization repository")
}
command.RunE = func(cmd *cobra.Command, args []string) error {
var id int64
var err error
prompted := false
opts := services.TeamOptions{}
if verb != "create" {
id, err = number(args[0])
if err != nil {
return err
}
}
if verb == "create" || verb == "edit" {
if err := oneOf("permission", permission, "read", "write", "admin"); err != nil {
return err
}
if cmd.Flags().Changed("unit") && (len(units) == 0 || permission == "admin") {
return clierr.Wrap(clierr.Usage, errors.New("--unit needs a nonempty policy and cannot restrict administrator access"))
}
for unit, access := range units {
if !teamUnitNames[unit] || (access != "none" && access != "read" && access != "write") {
return clierr.Wrap(clierr.Usage, errors.New("--unit requires repo.* keys with none, read, or write access"))
}
}
if verb == "create" {
prompted, err = a.require(cmd, &name, "name")
if err != nil {
return err
}
opts.Name = &name
opts.Permission = &permission
opts.CanCreateRepo = &createRepo
opts.AllRepositories = &allRepos
if !cmd.Flags().Changed("unit") {
opts.Units = map[string]string{"repo.code": permission, "repo.issues": permission, "repo.pulls": permission}
if permission == "admin" {
opts.Units = nil
}
}
}
if cmd.Flags().Changed("name") {
if strings.TrimSpace(name) == "" {
return clierr.Wrap(clierr.Usage, errors.New("team name cannot be empty"))
}
opts.Name = &name
}
if cmd.Flags().Changed("description") {
opts.Description = &description
}
if cmd.Flags().Changed("permission") {
opts.Permission = &permission
}
if cmd.Flags().Changed("unit") {
opts.Units = units
}
if cmd.Flags().Changed("can-create-repo") {
opts.CanCreateRepo = &createRepo
}
if cmd.Flags().Changed("all-repositories") {
opts.AllRepositories = &allRepos
}
if verb == "edit" && opts.Name == nil && opts.Description == nil && opts.Permission == nil && opts.Units == nil && opts.CanCreateRepo == nil && opts.AllRepositories == nil {
return clierr.Wrap(clierr.Usage, errors.New("supply team fields to edit"))
}
}
target, err := a.resolve(cmd.Context(), false)
if err != nil {
return err
}
service := services.Teams{Client: target.client}
if verb == "delete" || prompted {
subject := args[0]
if verb == "create" {
subject = name + " in " + args[0]
}
if err := a.confirm(cmd, verb+" team "+subject+" on "+target.Host); err != nil {
return err
}
}
var item services.Team
switch verb {
case "view":
item, err = service.View(cmd.Context(), id)
case "create":
item, err = service.Create(cmd.Context(), args[0], opts)
case "edit":
item, err = service.Edit(cmd.Context(), id, opts)
case "delete":
return service.Delete(cmd.Context(), id)
}
if err != nil {
return err
}
return writeItem(a, cmd, item, teamRow)
}
group.AddCommand(command)
}
group.AddCommand(a.teamAccessCommand(false), a.teamAccessCommand(true))
return group
}
func (a *application) teamAccessCommand(repository bool) *cobra.Command {
kind := "member"
if repository {
kind = "repo"
}
group := &cobra.Command{Use: kind, Short: "Manage team " + kind + " access"}
var limit, page int
list := &cobra.Command{Use: "list <id>", Short: "List team " + kind + "s", Args: argsExact(1), RunE: func(cmd *cobra.Command, args []string) error {
id, err := number(args[0])
if err != nil {
return err
}
target, err := a.resolve(cmd.Context(), false)
if err != nil {
return err
}
service := services.Teams{Client: target.client}
if repository {
items, err := service.Repositories(cmd.Context(), id, limit, page)
if err != nil {
return err
}
return writeList(a, cmd, items, func(item services.Repository) []terminal.Cell { return terminal.Row(item.FullName) })
}
items, err := service.Members(cmd.Context(), id, limit, page)
if err != nil {
return err
}
return writeList(a, cmd, items, func(item services.OrganizationMember) []terminal.Cell { return terminal.Row(item.Username) })
}}
pageFlags(list, &limit, &page)
group.AddCommand(list)
for _, verb := range []string{"add", "remove"} {
use := verb + " <id> <username>"
count := 2
if repository {
use = verb + " <id> --repo owner/repo"
count = 1
}
group.AddCommand(&cobra.Command{Use: use, Short: titleCase(verb) + " team " + kind + " access", Annotations: textOutput("team access changes do not return a resource"), Args: argsExact(count), RunE: func(cmd *cobra.Command, args []string) error {
id, err := number(args[0])
if err != nil {
return err
}
target, err := a.resolve(cmd.Context(), repository)
if err != nil {
return err
}
if verb == "remove" {
if err := a.confirm(cmd, "Remove team "+args[0]+" "+kind+" access"); err != nil {
return err
}
}
service := services.Teams{Client: target.client}
if repository {
return service.SetRepository(cmd.Context(), id, target.Repo, verb == "add")
}
return service.SetMember(cmd.Context(), id, args[1], verb == "add")
}})
}
return group
}
func teamRow(item services.Team) []terminal.Cell {
return terminal.Row(strconv.FormatInt(item.ID, 10), item.Name, item.Organization, item.Permission)
}