Files
gitea-tea/internal/services/errors.go
T
bircni dc43272085 feat: explain refusals to delete or rerun an unfinished run
Gitea refuses to delete or rerun a run that has not finished with "this
workflow run is not done". Report "run 37 has not finished; cancel it first:
tea run cancel 37", and cover the next steps added to refusals in tests.

Signed-off-by: bircni <bircni@icloud.com>
2026-10-11 22:48:50 +02:00

374 lines
14 KiB
Go

// Copyright 2026 The Gitea Authors. All rights reserved.
// SPDX-License-Identifier: MIT
package services
import (
"cmp"
"errors"
"net/http"
"regexp"
"slices"
"strconv"
"strings"
"gitea.dev/tea/internal/transport"
)
// CapabilityError reports an operation absent from the Gitea REST contract.
type CapabilityError struct{ Feature, Reason string }
func (e *CapabilityError) Error() string { return e.Feature + " is unsupported: " + e.Reason }
// NotFoundError reports a missing resource by the name the user gave it, such as
// "issue #999 not found in alice/project".
type NotFoundError struct {
// Kind names the resource, such as "issue" or "label".
Kind string
// Key identifies the resource as the user wrote it, such as "#999", "v1.0" or `"bug"`.
Key string
// Scope is the repository or organization that was searched; empty for instance-wide resources.
Scope string
// Err is the underlying failure, usually a 404 *transport.APIError.
Err error
}
func (e *NotFoundError) Error() string {
text := strings.TrimSpace(e.Kind+" "+e.Key) + " not found"
if e.Scope != "" {
text += " in " + e.Scope
}
return text
}
func (e *NotFoundError) Unwrap() error { return e.Err }
// NotFound reports that no kind named key exists in scope.
func NotFound(kind, key, scope string) *NotFoundError {
return &NotFoundError{Kind: kind, Key: key, Scope: scope}
}
// Reasons a ConflictError gives for refusing a request.
const (
ReasonArchived = "archived" // the repository is archived and read-only
ReasonExists = "exists" // a resource with the same identity already exists
ReasonMerged = "merged" // the pull request is already merged
ReasonDraft = "draft" // a draft pull request cannot be merged
ReasonOwnReview = "own review" // authors cannot approve or reject their own pull request
ReasonNoChanges = "no changes" // the head branch has no commits the base lacks
ReasonDisabled = "disabled" // the workflow is disabled
ReasonCompleted = "completed" // the run already finished
ReasonNotDone = "not done" // the run has not finished yet
ReasonKeyInUse = "key in use" // the SSH key is registered already
ReasonOwnsRepos = "owns repositories" // the user still owns repositories
)
// ConflictError reports a request the current state of a resource refuses, such as closing a
// merged pull request or writing to an archived repository.
type ConflictError struct {
// Reason is one of the Reason constants.
Reason string
// Kind, Key and Scope name the refused resource like NotFoundError; any may be empty.
Kind, Key, Scope string
// Hint is the next step, such as "use tea release edit v1.0"; callers add it.
Hint string
// Err is the underlying *transport.APIError.
Err error
}
func (e *ConflictError) Error() string {
subject := strings.TrimSpace(e.Kind + " " + e.Key)
var text string
switch e.Reason {
case ReasonArchived:
text = cmp.Or(e.Scope, "the repository") + " is archived (read-only)"
case ReasonExists:
text = cmp.Or(subject, "the resource") + " already exists"
if e.Scope != "" {
text += " in " + e.Scope
}
case ReasonMerged:
text = cmp.Or(subject, "the pull request") + " is already merged"
case ReasonDraft:
text = cmp.Or(subject, "the pull request") + " is a draft"
case ReasonOwnReview:
text = "you can't approve or request changes on your own pull request"
case ReasonNoChanges:
text = "no commits between the base and head branches"
case ReasonDisabled:
text = cmp.Or(subject, "the workflow") + " is disabled"
case ReasonCompleted:
text = cmp.Or(subject, "the run") + " is already completed"
case ReasonNotDone:
text = cmp.Or(subject, "the run") + " has not finished"
case ReasonKeyInUse:
text = "this SSH key is already registered"
case ReasonOwnsRepos:
text = cmp.Or(subject, "the user") + " still owns repositories"
default:
text = e.Err.Error()
}
if e.Hint != "" {
text += "; " + e.Hint
}
return text
}
func (e *ConflictError) Unwrap() error { return e.Err }
// AmbiguousError reports a name that matches several resources.
type AmbiguousError struct {
Kind, Key, Scope string
IDs []int64
}
func (e *AmbiguousError) Error() string {
ids := make([]string, len(e.IDs))
for i, id := range e.IDs {
ids[i] = strconv.FormatInt(id, 10)
}
text := e.Kind + " " + e.Key + " is ambiguous"
if e.Scope != "" {
text += " in " + e.Scope
}
return text + " (IDs " + strings.Join(ids, ", ") + "); pass an ID"
}
// refusals maps the messages Gitea gives for refused requests onto conflict reasons. Each entry
// lists lowercase message fragments; statuses, when set, limit an entry to those responses.
var refusals = []struct {
reason string
statuses []int
fragments []string
}{
{ReasonArchived, nil, []string{"is archived"}},
{ReasonMerged, nil, []string{"already merged"}},
{ReasonDraft, []int{http.StatusMethodNotAllowed}, []string{"work in progress", "draft"}},
{ReasonOwnReview, nil, []string{"approve your own pull", "reject your own pull"}},
{ReasonNoChanges, nil, []string{"no changes between the head and the base"}},
{ReasonDisabled, nil, []string{"workflow is disabled"}},
{ReasonCompleted, nil, []string{"already completed"}},
{ReasonNotDone, []int{http.StatusBadRequest}, []string{"not done"}},
{ReasonKeyInUse, nil, []string{"key content has been used"}},
{ReasonOwnsRepos, nil, []string{"ownership of repositories"}},
{ReasonExists, []int{http.StatusBadRequest, http.StatusConflict, http.StatusUnprocessableEntity}, []string{"already exist", "release is has no tag"}},
}
var (
// unknownUser finds the name in Gitea's "user does not exist [uid: 0, name: nobody]".
unknownUser = regexp.MustCompile(`user does not exist \[uid: \d+, name: ([^\]]+)\]`)
// pullTargets finds the branches in "pull request already exists for these targets [... head_branch: x, base_branch: y]".
pullTargets = regexp.MustCompile(`head_branch: ([^,\]]+), base_branch: ([^,\]]+)`)
// wikiTitle finds the page in "wiki page already exists [title: Home.md]".
wikiTitle = regexp.MustCompile(`\[title: (.+?)(?:\.md)?\]`)
)
// Classify names the resource of a failed request for the user: a 404 becomes a NotFoundError
// for kind key in scope, a refusal Gitea explains (archived repository, merged pull request,
// existing resource, ...) becomes a ConflictError, and an unknown user the request named becomes
// a NotFoundError for that user. Other errors are returned unchanged.
func Classify(err error, kind, key, scope string) error {
apiErr, ok := errors.AsType[*transport.APIError](err)
if !ok {
return err
}
if match := unknownUser.FindStringSubmatch(apiErr.Message); match != nil {
return &NotFoundError{Kind: "user", Key: strconv.Quote(match[1]), Err: err}
}
if reason := refusal(apiErr); reason != "" {
conflict := &ConflictError{Reason: reason, Kind: kind, Key: key, Scope: scope, Err: err}
if reason == ReasonArchived && kind == "repository" {
conflict.Kind, conflict.Key, conflict.Scope = "", "", key
}
if match := pullTargets.FindStringSubmatch(apiErr.Message); reason == ReasonExists && match != nil {
conflict.Kind, conflict.Key = "pull request", "for "+match[1]+" into "+match[2]
}
if match := wikiTitle.FindStringSubmatch(apiErr.Message); reason == ReasonExists && match != nil {
conflict.Kind, conflict.Key = "wiki page", strconv.Quote(match[1])
}
return conflict
}
if apiErr.Status == http.StatusNotFound && kind != "" {
return &NotFoundError{Kind: kind, Key: key, Scope: scope, Err: err}
}
return err
}
// refusal returns the conflict reason of a refused request, or "".
func refusal(apiErr *transport.APIError) string {
if apiErr.Status == http.StatusLocked {
return ReasonArchived
}
message := strings.ToLower(apiErr.Message)
for _, refusal := range refusals {
if refusal.statuses != nil && !slices.Contains(refusal.statuses, apiErr.Status) {
continue
}
for _, fragment := range refusal.fragments {
if strings.Contains(message, fragment) {
return refusal.reason
}
}
}
return ""
}
// ClassifyRequest is Classify for a failure no service classified: it infers the resource from
// the failed request's endpoint, so a 404 for GET /api/v1/repos/alice/x/issues/9 reports
// "issue #9 not found in alice/x".
func ClassifyRequest(err error) error {
apiErr, ok := errors.AsType[*transport.APIError](err)
if !ok {
return err
}
resource := RequestResource(apiErr.Endpoint)
kind, key := resource.Kind, resource.Key
// A refused POST to a collection concerns the resource it would have created.
if apiErr.Status != http.StatusNotFound && resource.Collection != "" {
kind, key = resource.Collection, ""
}
return Classify(err, kind, key, resource.Scope)
}
// Resource is what a Gitea API endpoint addresses.
type Resource struct {
// Kind and Key name one resource, such as "issue" and "#9"; both are empty for collections.
Kind, Key string
// Collection names the kind of resource a collection endpoint holds, such as "branch" for
// POST /repos/{owner}/{repo}/branches.
Collection string
// Scope is the repository or organization the resource belongs to.
Scope string
// Repository is the owner/name of a repository endpoint, else empty.
Repository string
// Section is the first path segment below the repository, such as "issues" or "pulls".
Section string
}
// RequestResource reports what endpoint, an API path such as /api/v1/repos/alice/x/issues/9,
// addresses.
func RequestResource(endpoint string) Resource {
_, rest, ok := strings.Cut(endpoint, "/api/v1/")
if !ok {
return Resource{}
}
parts := strings.Split(strings.Trim(rest, "/"), "/")
if len(parts) < 3 || parts[0] != "repos" {
return instanceResource(parts)
}
repo := parts[1] + "/" + parts[2]
if len(parts) == 3 {
return Resource{Kind: "repository", Key: repo, Repository: repo}
}
resource := repositoryResource(parts[3:])
resource.Repository, resource.Scope, resource.Section = repo, repo, parts[3]
return resource
}
// collections names the resources that POST to a repository collection creates.
var collections = map[string]string{
"branches": "branch", "tags": "tag", "releases": "release", "labels": "label", "milestones": "milestone",
"pulls": "pull request", "issues": "issue", "hooks": "webhook", "keys": "deploy key", "wiki": "wiki page",
}
// repositoryResource matches the path below /repos/{owner}/{repo}.
func repositoryResource(parts []string) Resource {
at := func(i int) string {
if i < len(parts) {
return parts[i]
}
return ""
}
rest := func(i int) string { return strings.Join(parts[min(i, len(parts)):], "/") }
switch {
case at(0) == "issues" && at(1) == "comments" && at(2) != "":
return Resource{Kind: "comment", Key: at(2)}
case (at(0) == "issues" || at(0) == "pulls") && isNumber(at(1)):
kind := "issue"
if at(0) == "pulls" {
kind = "pull request"
}
return Resource{Kind: kind, Key: "#" + at(1)}
case at(0) == "releases" && at(1) == "tags" && at(2) != "":
return Resource{Kind: "release", Key: rest(2)}
case at(0) == "releases" && at(2) == "assets" && at(3) != "":
return Resource{Kind: "release asset", Key: at(3)}
case at(0) == "releases" && isNumber(at(1)):
return Resource{Kind: "release", Key: at(1)}
case at(0) == "labels" && at(1) != "":
return Resource{Kind: "label", Key: at(1)}
case at(0) == "milestones" && at(1) != "":
return Resource{Kind: "milestone", Key: nameKey(at(1))}
case at(0) == "branches" && at(1) != "":
return Resource{Kind: "branch", Key: rest(1)}
case at(0) == "branch_protections" && at(1) != "":
return Resource{Kind: "branch protection", Key: rest(1)}
case at(0) == "tags" && at(1) != "":
return Resource{Kind: "tag", Key: rest(1)}
case at(0) == "wiki" && (at(1) == "page" || at(1) == "revisions") && at(2) != "":
return Resource{Kind: "wiki page", Key: strconv.Quote(at(2))}
case at(0) == "hooks" && isNumber(at(1)):
return Resource{Kind: "webhook", Key: at(1)}
case at(0) == "collaborators" && at(1) != "":
return Resource{Kind: "collaborator", Key: strconv.Quote(at(1))}
case at(0) == "contents" && at(1) != "":
return Resource{Kind: "file", Key: rest(1)}
case at(0) == "actions":
return actionsResource(at(1), at(2))
}
return Resource{Collection: collections[at(0)]}
}
func actionsResource(collection, key string) Resource {
kinds := map[string]string{"runs": "run", "jobs": "job", "artifacts": "artifact", "workflows": "workflow", "secrets": "secret", "variables": "variable"}
kind := kinds[collection]
if key == "" {
return Resource{Collection: kind}
}
return Resource{Kind: kind, Key: key}
}
// instanceResource matches endpoints outside a repository, such as /users/{name}.
func instanceResource(parts []string) Resource {
at := func(i int) string {
if i < len(parts) {
return parts[i]
}
return ""
}
switch {
case at(0) == "orgs" && at(1) != "" && (at(2) == "members" || at(2) == "public_members") && at(3) != "":
return Resource{Kind: "member", Key: strconv.Quote(at(3)), Scope: at(1)}
case at(0) == "orgs" && at(1) != "" && at(2) == "repos":
return Resource{Kind: "organization", Key: strconv.Quote(at(1)), Collection: "repository"}
case at(0) == "orgs" && at(1) != "":
return Resource{Kind: "organization", Key: strconv.Quote(at(1))}
case at(0) == "users" && at(1) != "":
return Resource{Kind: "user", Key: strconv.Quote(at(1))}
case at(0) == "admin" && at(1) == "users" && at(2) != "":
return Resource{Kind: "user", Key: strconv.Quote(at(2))}
case at(0) == "teams" && isNumber(at(1)):
return Resource{Kind: "team", Key: at(1)}
case at(0) == "user" && at(1) == "keys" && at(2) != "":
return Resource{Kind: "SSH key", Key: at(2)}
case at(0) == "user" && at(1) == "repos":
return Resource{Collection: "repository"}
case at(0) == "notifications" && at(1) == "threads" && at(2) != "":
return Resource{Kind: "notification", Key: at(2)}
}
return Resource{}
}
// nameKey quotes a name, but not a numeric ID.
func nameKey(value string) string {
if isNumber(value) {
return value
}
return strconv.Quote(value)
}
func isNumber(value string) bool {
n, err := strconv.ParseInt(value, 10, 64)
return err == nil && n > 0
}