Edit CONTRIBUTING.md

This commit is contained in:
Hyeonho Kang 2025-01-17 00:36:37 +09:00
parent ef92cc70c9
commit 2e8d4a1128

View File

@ -1,21 +1,21 @@
### Contributions / participation
### Contribution
is always welcome, here @ github or via e-mail.
Contribution is always welcome, submit here (GitHub) or via e-mail.
Note please the following
Please note the following:
* Please read at least the [coding convention](https://github.com/testssl/testssl.sh/Coding_Convention.md).
* One PR per feature or bug fix or improvement. Please do not mix issues.
* Document your PR, both in the PR and/or commit message and in the code.
* Please read at least the [coding convention](https://github.com/testssl/testssl.sh/blob/3.2/Coding_Convention.md).
* One Pull Request per feature or bug fix or improvement. Please do not mix issues.
* Document your Pull Request, both in the Pull Request and/or commit message and in the code.
* Please test your changes thoroughly as reliability is important for this project. You may want to check different servers with different settings.
* Travis runs automatically when anything is committed/PR'd. You should check any complains from Travis. Beforehand you can check with `prove -v`.
* If it's a new feature please consider writing a unit test for it. You can use e.g. `t/20_baseline_ipv4_http.t` as a template. The general documentation for [Test::More](https://perldoc.perl.org/Test/More.html) is a good start.
* If it's a new feature it would need to be documented in the appropriate section in `help()` and in `~/doc/testssl.1.md`
* Travis runs automatically when anything is committed/pull requested. You should check any complains from Travis. Beforehand you can check with `prove -v`.
* If it's a new feature, please consider writing a unit test for it. You can use e.g. `t/20_baseline_ipv4_http.t` as a template. The general documentation for [Test::More](https://perldoc.perl.org/Test/More.html) is a good start.
* If it's a new feature, it would need to be documented in the appropriate section in `help()` and in `~/doc/testssl.1.md`
For questions just open an issue or feel free to send me an e-mail.
For the questions, just open an issue or feel free to send us an e-mail.
#### Patches via e-mail
#### Contribute via e-mail
Of course it is fine when you want to send in patches to use e-mail. For the address please grep for SWCONTACT in testssl.sh .
Of course it is fine when you want to send in patches to use e-mail. For the address, please grep for SWCONTACT in testssl.sh.
Let me know how you like them to be attributed.