Commit Graph

3676 Commits

Author SHA1 Message Date
5d2d9f2c00 Merge pull request #2652 from testssl/address_addCA_issue_3.0
Address CA file parsing problem
2025-02-07 12:28:47 +01:00
b0c026ecc3 Address CA file parsing problem
.... by forbidding spaces in supplied CA files/directories

Also now we're sanitizing the cmd line parameter better `using safe_echo()`

See also #2647 .
2025-02-07 11:23:13 +01:00
e69a29ca0c Merge pull request #2637 from testssl/fix_2633_3.0
Fix bug when legacy NPN is tested against a TLS 1.3 host
2025-01-24 20:40:05 +01:00
7597360775 fix typo 2025-01-24 19:38:44 +01:00
f321bcf1ed Fix bug when legacy NPN is tested against a TLS 1.3 host (3.0)
When testing a TLS 1.3 host s_client_options used TLS 1.3 ciphers to test for NPN. As that is not implemented we nee dto make sure any other version is used.
This PR ensures that --after testing whether it's a TLS 1.3-only host where this test doesn't make any sense in the first place.

Fix for #2633
2025-01-24 19:38:02 +01:00
439937feb9 Merge pull request #2630 from testssl/fix_roundbracket_in_header
Fix place for round bracket for header and remove obsolete comment
2025-01-23 12:43:55 +01:00
7a6efd9483 Remove +-sign from c&p'ed diff 2025-01-23 11:32:53 +01:00
c482df82bd Fix place for round bracket and remove obsolete header
This was done in 3.2 previously, see commit 4efe324ef7 .
As everything was sanitized, the comment was removed.
2025-01-23 10:51:55 +01:00
b1f279f6af Merge pull request #2627 from dcooper16/fix_x25519_and_x448_check_30
Fix checks for whether X25519 and X448 are supported
2025-01-22 17:49:26 +01:00
2b0482359d Fix checks for whether X25519 and X448 are supported
In some cases OpenSSL returns an "unsupported" message rather than a "not found" message if X25519 and X448 are not supported. This commit changes the check for whether X5519 and X448 are supported for checking for either response.
2025-01-22 06:12:11 -08:00
b4274e8d65 Merge pull request #2603 from dcooper16/fix2599_30
Fix #2599
2024-11-27 11:36:22 +01:00
06c28bdb45 Fix #2599
This commit fixes #2599 by not wrapping fileout() messages in a "clientProblem" wrapper if TLS13_ONLY is set. The TLS13_ONLY flag being set is an indicator that fileout_banner() has already been called.
2024-11-26 10:53:54 -08:00
6570c20798 Merge pull request #2581 from drwetter/fix_2575-3.0
Fix json/csv output when STARTTLS problem is passed back (3.0)
2024-10-14 17:06:41 +02:00
c2ed4d55da Fix json/csv output when STARTTLS problem is passed back (3.0)
In rare cases testssl.sh writes to the terminal output "likely not offered" but misses the "likely" in the json/csv output.

This fixes #2575 for the 3.0 branch by adding that word and amending the return value 4 with a comment.
2024-10-14 16:26:23 +02:00
d248451340 Merge pull request #2578 from drwetter/fix_f5_short_rfc1918.3.0
Fix F5 cookie in 10.x.x.x.  (3.0)
2024-10-13 10:50:19 +02:00
968e5509ad Fix F5 cookie in 10.x.x.x. (3.0)
The F5 cookie decoder doesn't detect IPs in the 10.x.x.x space for non-encrypted cookies. This fixes the regex pattern, see also
https://github.com/drwetter/F5-BIGIP-Decoder/pull/4 and https://github.com/drwetter/testssl.sh/pull/2577
2024-10-12 21:06:21 +02:00
eee26817c5 Merge pull request #2560 from drwetter/fix_docker_3.0
Fix the Dockerfile (3.0) env (hopefully)
2024-09-05 17:59:26 +02:00
73fa5607d8 restrict CI run to pull 2024-09-05 17:55:44 +02:00
cebb52f698 Fix the Dockerfile env (hopefully)
* Upgrade both GHCR and Docker hub foile to alpine 3.2
* uses openssl version 3.3 as a alternative to option (default is still "ours"
* docker 3.0 yml hast now ubuntu-22.04 (not EOL) + "latest" omitted
2024-09-05 17:44:33 +02:00
1296279fa9 Merge pull request #2554 from drwetter/noCtrlCharInHeader_3.0
No ctrl char in header (3.0)
2024-09-03 20:50:00 +02:00
27f996d99f Remove crtl chars from HTTP header (3.0)
... which fixes #2337
2024-09-03 19:33:09 +02:00
6ce7b643ed Merge pull request #2550 from drwetter/banner_3.0
Improve banner (3.0)
2024-09-03 19:13:36 +02:00
196cd53dd5 Fix CI 2024-09-03 18:25:32 +02:00
ac81c182b1 Fix CI 2024-09-03 18:24:51 +02:00
52374e552e handle spell errors 2024-09-03 15:27:42 +02:00
44a60ff80b Improve banner (3.0)
... for readablity and bugs to be filed (see #2506)

This PR defines a short string for the OpenSSL banner as some suppliers have
makde them (unnecessarily) long so that it won't fit in the banner.

The banner also now omits the built line nad bash version when scanning
as for the user it is normally not important.
2024-09-03 15:17:23 +02:00
6d714d6b99 Merge pull request #2546 from drwetter/fix_2542_3.0
fix typo
2024-08-26 10:44:30 +02:00
69d3cff51c fix typo 2024-08-26 10:42:34 +02:00
7db944e584 Merge pull request #2536 from drwetter/update_CAstores-3.0
Update Truststores (3.0)
2024-07-24 09:28:39 +02:00
887f21609a Update Truststores (3.0)
Same as #2528, only for the 3.0 branch.

- Mozilla: 2024-7-02
- Debian 12, ca-certificates from 20230311
- JDK 21.04
- Apple via https://github.com/apple-oss-distributions/security_certificates (according to git log latest change Fri Dec 15 00:44:35 2023)
- Microsoft via CertUtil (date of this PR)

Modified Readme to reflect that the Apple CA certificates are better to retrieve from GH and clarified minor things.

This also fixes #2525 (for 3.0), where >=2 certificates were missing.
2024-07-23 12:20:09 +02:00
08a430e01a Merge pull request #2531 from drwetter/fix_ipv6_ula_and_more-3.0
Fix IPv6 addresses (3.0)
2024-07-22 23:31:55 +02:00
33993d4174 Fix IPv6 addresses (3.0)
Local and ULA and other IPv6 adresses were incorrectly filtered by ``awk '/^[0-9]/ { print $1 }'`` which searches in the first term for numeric values only.

This PR adds a-f and fixes #2529 for the 3.0 branch.
2024-07-22 21:17:16 +02:00
4f9bfbc47c Merge pull request #2508 from drwetter/make_rel3.0
Prepare for release 3.0
v3.0.9
2024-06-13 18:32:28 +02:00
3cb2371744 Make ready for release
* bump version
* modify banner and issue template to address #2506

Needed to modify the banner a bit for space reasons. Looks catchier
though.
2024-06-13 17:28:46 +02:00
05fb5f97bf Merge pull request #2507 from drwetter/codespell_2502
Fix spelling issues in #2503
2024-06-13 15:39:17 +02:00
54d1784203 add file, previously forgotten 2024-06-13 15:21:13 +02:00
3beeedcaf0 Fix spelling issues in #2502 2024-06-13 15:19:10 +02:00
9c2bfff1bf Merge pull request #2505 from dcooper16/fix2502_30
Fix #2502 in 3.0 branch
2024-06-13 15:12:57 +02:00
acdbdcf552 Fix #2502 in 3.0 branch
This commit fixes drwetter#2502 in the 3.0 branch by checking that the key_share extension is at least 4 bytes long (8 in ASCII-HEX). These 4 bytes encode the group value (2 bytes) and the length of the key (2 bytes).
2024-06-13 05:56:21 -07:00
212bdbb78e Merge pull request #2485 from drwetter/fix_CAARRquery_noDNS_30
Fix CAA query when nodns set
2024-05-26 17:40:10 +02:00
83059ca5ee Fixes DNS CAA query when no query option set 2024-03-30 17:33:55 +01:00
30c0359bdd Merge pull request #2471 from Tazmaniac/mongodb-detection-fix-backport
MongoDB identification fix
2024-02-13 18:42:33 +01:00
c98c780ded MongoDB identification fix
The actual code grep for "MongoDB" keyword in the head of the HTTP
session.
In case of "compressed" HTML, a big page is on one line.
On a IT page, we could encounter the "MongoDB" keyword and
miss-identify the application protocol.

Fixed by matching on a longuer string taken from a live MogoDB
server.
2024-02-13 17:48:40 +01:00
208efdc68a Merge pull request #2452 from drwetter/update_hashes_3.0
Update hashes for HPKP
2023-12-24 15:33:28 +01:00
0de86283e9 Update hashes for HPKP 2023-12-24 13:57:48 +01:00
0de609da8c Merge pull request #2451 from drwetter/fix_stupid_umaskerror_3.0
Bail out if user error bc of umask (3.0 branch)
2023-12-24 11:12:29 +01:00
02220d2fc4 Bail out if user error bc of umask (3.0 branch)
Implemnation for 3.0, 3.2 see #2450

If a user chose a broken umask testssl.sh will start but emits subsequent errors.
This patch adds two sanity checks whether it is allowed to create and read files in the temp directory.

Fixes #2449
2023-12-24 10:21:11 +01:00
68dec54cc5 Merge pull request #2435 from drwetter/fix_2431_grepProb
Amend fix for newer grep versions
2023-10-30 20:29:59 +01:00
a0c0c73b66 Amend fix for newer grep versions
See also PR #2243, issue #2241

Removes unneeded escape for exclamation mark. This is for 3.0.
3.2 has the fix already.
2023-10-30 19:07:06 +01:00
40c6be790b Merge pull request #2434 from drwetter/fix_2429_3.0
Fix weird bash globbing (3.0)
2023-10-30 17:53:19 +01:00