Commit Graph
100 Commits
Author SHA1 Message Date
Dirk WetterandGitHub 7937c0b845 Merge pull request #2696 from testssl/fix_segfault_error4-3.0
Fix segfault with error 4 in check_revocation_ocsp() when using --phone-out (3.0)
2025-03-14 19:19:16 +01:00
Dirk 8d019855a3 Fix segfault with error 4 in check_revocation_ocsp() when using --phone-out (3.0)
As `--phone-out` sometimes doesn't work with our binary we switch transparently/automagically
to the vendor support openssl binary -- if available. This is the PR for 3.0, for 3.2 see #2695 .

This fixes at least #2516 where the issue has been explained/debugged in detail.
See also #2667 and #1275.
2025-03-14 17:15:40 +01:00
Dirk WetterandGitHub ab0b829d36 Merge pull request #2668 from krufab/fix/fix-typo-in-help-message
Corrected typo in help message
2025-02-23 14:29:45 +01:00
Dirk WetterandGitHub d2550395a7 Merge pull request #2663 from dcooper16/fix_ossl_supported_curve_check_30
Fix check for OpenSSL supported curves
2025-02-20 11:31:45 +01:00
Dirk WetterandGitHub 94b590f0af Merge pull request #2658 from dcooper16/fix_pattern_match_30
Fix pattern matches
2025-02-15 14:15:32 +01:00
Dirk WetterandGitHub c49d9f67fa Merge pull request #2654 from testssl/drwetter-patch-1
Update workflows to Ubuntu 24.04
2025-02-12 16:22:28 +01:00
Dirk WetterandGitHub 65200f4a7e Update test.yml 2025-02-12 16:21:33 +01:00
Dirk WetterandGitHub bd88c844db Update docker-3.0.yml 2025-02-12 16:21:04 +01:00
Dirk WetterandGitHub 7174521b3d Update test.yml to Ububutu 22.04
Warning from Github that this will be out of service in April 1st.
2025-02-12 16:17:23 +01:00
Dirk WetterandGitHub 01dd7a4bd4 Merge pull request #2651 from testssl/readme_update_3.0
Update Readme drwetter --> testssl
2025-02-07 12:29:36 +01:00
Dirk WetterandGitHub 5d2d9f2c00 Merge pull request #2652 from testssl/address_addCA_issue_3.0
Address CA file parsing problem
2025-02-07 12:28:47 +01:00
Dirk Wetter b0c026ecc3 Address CA file parsing problem
.... by forbidding spaces in supplied CA files/directories

Also now we're sanitizing the cmd line parameter better `using safe_echo()`

See also #2647 .
2025-02-07 11:23:13 +01:00
Dirk Wetter 305ce18931 Update Readme drwetter --> testssl
and some links in testssl.sh
2025-02-07 10:58:41 +01:00
Dirk WetterandGitHub e69a29ca0c Merge pull request #2637 from testssl/fix_2633_3.0
Fix bug when legacy NPN is tested against a TLS 1.3 host
2025-01-24 20:40:05 +01:00
Dirk 7597360775 fix typo 2025-01-24 19:38:44 +01:00
Dirk f321bcf1ed Fix bug when legacy NPN is tested against a TLS 1.3 host (3.0)
When testing a TLS 1.3 host s_client_options used TLS 1.3 ciphers to test for NPN. As that is not implemented we nee dto make sure any other version is used.
This PR ensures that --after testing whether it's a TLS 1.3-only host where this test doesn't make any sense in the first place.

Fix for #2633
2025-01-24 19:38:02 +01:00
Dirk WetterandGitHub 439937feb9 Merge pull request #2630 from testssl/fix_roundbracket_in_header
Fix place for round bracket for header and remove obsolete comment
2025-01-23 12:43:55 +01:00
Dirk Wetter 7a6efd9483 Remove +-sign from c&p'ed diff 2025-01-23 11:32:53 +01:00
Dirk Wetter c482df82bd Fix place for round bracket and remove obsolete header
This was done in 3.2 previously, see commit 4efe324ef7 .
As everything was sanitized, the comment was removed.
2025-01-23 10:51:55 +01:00
Dirk WetterandGitHub b1f279f6af Merge pull request #2627 from dcooper16/fix_x25519_and_x448_check_30
Fix checks for whether X25519 and X448 are supported
2025-01-22 17:49:26 +01:00
Dirk WetterandGitHub b4274e8d65 Merge pull request #2603 from dcooper16/fix2599_30
Fix #2599
2024-11-27 11:36:22 +01:00
Dirk WetterandGitHub 6570c20798 Merge pull request #2581 from drwetter/fix_2575-3.0
Fix json/csv output when STARTTLS problem is passed back (3.0)
2024-10-14 17:06:41 +02:00
Dirk c2ed4d55da Fix json/csv output when STARTTLS problem is passed back (3.0)
In rare cases testssl.sh writes to the terminal output "likely not offered" but misses the "likely" in the json/csv output.

This fixes #2575 for the 3.0 branch by adding that word and amending the return value 4 with a comment.
2024-10-14 16:26:23 +02:00
Dirk WetterandGitHub d248451340 Merge pull request #2578 from drwetter/fix_f5_short_rfc1918.3.0
Fix F5 cookie in 10.x.x.x.  (3.0)
2024-10-13 10:50:19 +02:00
Dirk Wetter 968e5509ad Fix F5 cookie in 10.x.x.x. (3.0)
The F5 cookie decoder doesn't detect IPs in the 10.x.x.x space for non-encrypted cookies. This fixes the regex pattern, see also
https://github.com/drwetter/F5-BIGIP-Decoder/pull/4 and https://github.com/drwetter/testssl.sh/pull/2577
2024-10-12 21:06:21 +02:00
Dirk WetterandGitHub eee26817c5 Merge pull request #2560 from drwetter/fix_docker_3.0
Fix the Dockerfile (3.0) env (hopefully)
2024-09-05 17:59:26 +02:00
Dirk 73fa5607d8 restrict CI run to pull 2024-09-05 17:55:44 +02:00
Dirk cebb52f698 Fix the Dockerfile env (hopefully)
* Upgrade both GHCR and Docker hub foile to alpine 3.2
* uses openssl version 3.3 as a alternative to option (default is still "ours"
* docker 3.0 yml hast now ubuntu-22.04 (not EOL) + "latest" omitted
2024-09-05 17:44:33 +02:00
Dirk WetterandGitHub 1296279fa9 Merge pull request #2554 from drwetter/noCtrlCharInHeader_3.0
No ctrl char in header (3.0)
2024-09-03 20:50:00 +02:00
Dirk 27f996d99f Remove crtl chars from HTTP header (3.0)
... which fixes #2337
2024-09-03 19:33:09 +02:00
Dirk WetterandGitHub 6ce7b643ed Merge pull request #2550 from drwetter/banner_3.0
Improve banner (3.0)
2024-09-03 19:13:36 +02:00
Dirk 196cd53dd5 Fix CI 2024-09-03 18:25:32 +02:00
Dirk ac81c182b1 Fix CI 2024-09-03 18:24:51 +02:00
Dirk 52374e552e handle spell errors 2024-09-03 15:27:42 +02:00
Dirk 44a60ff80b Improve banner (3.0)
... for readablity and bugs to be filed (see #2506)

This PR defines a short string for the OpenSSL banner as some suppliers have
makde them (unnecessarily) long so that it won't fit in the banner.

The banner also now omits the built line nad bash version when scanning
as for the user it is normally not important.
2024-09-03 15:17:23 +02:00
Dirk WetterandGitHub 6d714d6b99 Merge pull request #2546 from drwetter/fix_2542_3.0
fix typo
2024-08-26 10:44:30 +02:00
Dirk Wetter 69d3cff51c fix typo 2024-08-26 10:42:34 +02:00
Dirk WetterandGitHub 7db944e584 Merge pull request #2536 from drwetter/update_CAstores-3.0
Update Truststores (3.0)
2024-07-24 09:28:39 +02:00
Dirk 887f21609a Update Truststores (3.0)
Same as #2528, only for the 3.0 branch.

- Mozilla: 2024-7-02
- Debian 12, ca-certificates from 20230311
- JDK 21.04
- Apple via https://github.com/apple-oss-distributions/security_certificates (according to git log latest change Fri Dec 15 00:44:35 2023)
- Microsoft via CertUtil (date of this PR)

Modified Readme to reflect that the Apple CA certificates are better to retrieve from GH and clarified minor things.

This also fixes #2525 (for 3.0), where >=2 certificates were missing.
2024-07-23 12:20:09 +02:00
Dirk WetterandGitHub 08a430e01a Merge pull request #2531 from drwetter/fix_ipv6_ula_and_more-3.0
Fix IPv6 addresses (3.0)
2024-07-22 23:31:55 +02:00
Dirk 33993d4174 Fix IPv6 addresses (3.0)
Local and ULA and other IPv6 adresses were incorrectly filtered by ``awk '/^[0-9]/ { print $1 }'`` which searches in the first term for numeric values only.

This PR adds a-f and fixes #2529 for the 3.0 branch.
2024-07-22 21:17:16 +02:00
Dirk WetterandGitHub 4f9bfbc47c Merge pull request #2508 from drwetter/make_rel3.0
Prepare for release 3.0
2024-06-13 18:32:28 +02:00
Dirk 3cb2371744 Make ready for release
* bump version
* modify banner and issue template to address #2506

Needed to modify the banner a bit for space reasons. Looks catchier
though.
2024-06-13 17:28:46 +02:00
Dirk WetterandGitHub 05fb5f97bf Merge pull request #2507 from drwetter/codespell_2502
Fix spelling issues in #2503
2024-06-13 15:39:17 +02:00
Dirk 54d1784203 add file, previously forgotten 2024-06-13 15:21:13 +02:00
Dirk 3beeedcaf0 Fix spelling issues in #2502 2024-06-13 15:19:10 +02:00
Dirk WetterandGitHub 9c2bfff1bf Merge pull request #2505 from dcooper16/fix2502_30
Fix #2502 in 3.0 branch
2024-06-13 15:12:57 +02:00
Dirk WetterandGitHub 212bdbb78e Merge pull request #2485 from drwetter/fix_CAARRquery_noDNS_30
Fix CAA query when nodns set
2024-05-26 17:40:10 +02:00
Dirk 83059ca5ee Fixes DNS CAA query when no query option set 2024-03-30 17:33:55 +01:00
Dirk WetterandGitHub 30c0359bdd Merge pull request #2471 from Tazmaniac/mongodb-detection-fix-backport
MongoDB identification fix
2024-02-13 18:42:33 +01:00
Dirk WetterandGitHub 208efdc68a Merge pull request #2452 from drwetter/update_hashes_3.0
Update hashes for HPKP
2023-12-24 15:33:28 +01:00
Dirk 0de86283e9 Update hashes for HPKP 2023-12-24 13:57:48 +01:00
Dirk WetterandGitHub 0de609da8c Merge pull request #2451 from drwetter/fix_stupid_umaskerror_3.0
Bail out if user error bc of umask (3.0 branch)
2023-12-24 11:12:29 +01:00
Dirk Wetter 02220d2fc4 Bail out if user error bc of umask (3.0 branch)
Implemnation for 3.0, 3.2 see #2450

If a user chose a broken umask testssl.sh will start but emits subsequent errors.
This patch adds two sanity checks whether it is allowed to create and read files in the temp directory.

Fixes #2449
2023-12-24 10:21:11 +01:00
Dirk WetterandGitHub 68dec54cc5 Merge pull request #2435 from drwetter/fix_2431_grepProb
Amend fix for newer grep versions
2023-10-30 20:29:59 +01:00
Dirk a0c0c73b66 Amend fix for newer grep versions
See also PR #2243, issue #2241

Removes unneeded escape for exclamation mark. This is for 3.0.
3.2 has the fix already.
2023-10-30 19:07:06 +01:00
Dirk WetterandGitHub 40c6be790b Merge pull request #2434 from drwetter/fix_2429_3.0
Fix weird bash globbing (3.0)
2023-10-30 17:53:19 +01:00
Dirk 41c697f232 put the redirection in the right spot 2023-10-30 15:25:38 +01:00
Dirk 775ed60437 Fix weird bash globbing (3.0)
What was problematic was the error message when the certificate stores were missing. This fixes it by redirecting the error message to /dev/null so that if the sub function detects the missing file it returns with an error by the program and not by executing "basename"

As for 3.2 this is for the 3.0 branch.
2023-10-30 15:20:37 +01:00
Dirk WetterandGitHub 7df05511da Merge pull request #2426 from drwetter/drwetter-patch-2
Sync GHCR with Dockerfile
2023-10-30 14:41:12 +01:00
Dirk WetterandGitHub 382c1530cb Sync GHCR with Dockerfile 2023-10-13 17:38:09 +02:00
Dirk WetterandGitHub 3eb3994d39 Merge pull request #2421 from drwetter/alpine_3.18
Update Dockerfile to Alpine 3.18
2023-10-13 10:43:56 +02:00
Dirk WetterandGitHub cd6659c7ad Update Dockerfile to Alpine 3.18
for an extension of life time:

https://endoflife.date/alpine
2023-10-12 09:59:25 +02:00
Dirk WetterandGitHub ece9447ac4 Merge pull request #2412 from drwetter/fix_extended_regexp3.0
Fix regexp in STARTTLS detection
2023-10-07 17:21:25 +02:00
Dirk c09e1587b7 fix spell errors 2023-10-07 15:15:04 +02:00
Dirk c31b9492ce Fix regexp in STARTTLS detection
see also #2411, kudo to Geert!
2023-10-07 15:06:36 +02:00
Dirk WetterandGitHub e9cd8c3afd Merge pull request #2391 from Tazmaniac/Renego-backport-patch
Backport pull request #2360 to fix #2389
2023-09-08 19:20:38 +02:00
Dirk WetterandGitHub 5cb30aa510 Merge pull request #2342 from drwetter/openssl_link_docker_3.0
make openssl 1.1 available via /usr/bin/openssl
2023-03-20 14:29:14 +01:00
Dirk f65b81837c make openssl 1.1 available via /usr/bin/openssl 2023-03-20 14:19:35 +01:00
Dirk WetterandGitHub 4c54464ab8 Merge pull request #2341 from drwetter/fix_nss_dns_3.0
Modify Dockerfile.git also, amending #2340
2023-03-20 13:42:59 +01:00
Dirk Wetter bf88b8b443 Modify Dockerfile.git also, amending #2340 2023-03-19 22:57:58 +01:00
Dirk WetterandGitHub 6454f656db Merge pull request #2340 from drwetter/fix_nss_dns_3.0
Add openssl, offer to query OCSP responder (3.0)
2023-03-19 22:52:33 +01:00
Dirk Wetter 8759ac61af Add openssl, offer to query OCSP responder
This PR includes two tweaks:

* it helps avoiding the bug querying OCSP responder #2329 by adding
  openssl. The openssl supplied has a mimor DNS lookup problem due
  to glibc / musl libc compatibilty issues
* by adding openssl also it helps a bit for some performance problems
  related to other projects, see #2314

Also the git binary is removed (#2315).

Thanks to @polarathene for the discussions
2023-03-19 22:41:17 +01:00
Dirk WetterandGitHub 30022ea697 Merge pull request #2339 from drwetter/CAstores_update_3.0
Update CA root stores
2023-03-19 22:27:36 +01:00
Dirk Wetter ad44f7d53e Update CA root stores 2023-03-18 22:57:52 +01:00
Dirk WetterandGitHub e9c0beb3f7 Merge pull request #2335 from drwetter/sanitize_fileout_3.0
Backport: Make sure control chars from HTTP header don't end up in …
2023-03-12 18:19:09 +01:00
Dirk Wetter 828af39053 Backporting Make sure control chars from HTTP header don't end up in html,csv,json
This is for 3.0. For 3.1dev, see #2332 .

This PR addresses the bug #2330 by implementing a function which removes control characters from the file output format html,csv,json in the output.
In every instance called there's a check before whether the string contains control chars, hoping it'll save a few milli seconds.

A tr function is used, omitting LF.
It doesn't filter the terminal output and the log file output, yet. It provides a function though which is not being called.
2023-03-12 17:40:02 +01:00
Dirk WetterandGitHub 34453664a1 Merge pull request #2334 from drwetter/drwetter-patch-5
Update .gitignore
2023-03-12 16:13:21 +01:00
Dirk Wetter d662b7bfec add .git dir
see https://github.com/codespell-project/actions-codespell/issues/56
2023-03-12 16:10:56 +01:00
Dirk Wetter 16450e3d4f add codespell corrections (aNULL) 2023-03-12 16:06:02 +01:00
Dirk WetterandGitHub d6c0b33736 Update .gitignore
sync with 3.1dev
2023-03-12 15:59:47 +01:00
Dirk WetterandGitHub b8bb3ef747 Merge pull request #2327 from drwetter/fix_mime-type-3.0
Fix Accept Header (3.0)
2023-02-20 20:29:46 +01:00
Dirk 96a4eb99ad Fix Accept Header (3.0)
see #2325. This is for the 3.0 branch (for 3.1dev see #2326)

"whenever HTTP/1.1 is used then the Accept header uses "text/*" as a MIME type.
This causes some minor issues with some of the checks we are doing"
2023-02-20 15:14:34 +01:00
Dirk WetterandGitHub bd310489d1 Merge pull request #2322 from dcooper16/30_no_grade
Remove set_grade_cap() from 3.0
2023-02-07 08:59:09 +01:00
Dirk WetterandGitHub 3bacce4770 Merge pull request #2319 from SSLbrain/3.0
Feature request Trustcor certificate #2293 for 3.0
2023-02-05 19:21:15 +01:00
Dirk WetterandGitHub 4a2b258425 Merge pull request #2318 from dcooper16/fix_html_30
Fix HTML output in Bash 5.2 and newer
2023-02-04 09:24:07 +01:00
Dirk WetterandGitHub cd2eef30ea Merge pull request #2307 from drwetter/upgrade_alpine_perf-fix-3.0
Upgrade Alpine version for both Dockerfiles (3.0)
2023-02-01 19:49:12 +01:00
Dirk Wetter cd66c90054 Upgrade Alpine version for both Dockerfiles (3.0)
... to improve/mitigate performance problems, see #2299. (musl libc vs. glibc)

Same PR as for 3.1dev branch: #2306
2023-02-01 19:47:38 +01:00
Dirk WetterandGitHub d01ded1fd0 Merge pull request #2283 from drwetter/drwetter-patch-3
Reflect past update for Dockerfile (3.0) for ghcr
2022-11-28 17:09:37 +01:00
Dirk WetterandGitHub 801930736f Reflect past update for Dockerfile (3.0) for ghcr
... using alpine 3.15
2022-11-28 14:13:56 +01:00
Dirk WetterandGitHub 6b91a60a7a Merge pull request #2274 from dcooper16/fix2249
Fix #2249
2022-11-11 16:30:12 +01:00
Dirk WetterandGitHub 3261e6e7a9 Merge pull request #2273 from dcooper16/fix2271_30
Fix #2271
2022-11-11 16:28:48 +01:00
Dirk WetterandGitHub 52fe210e76 Merge pull request #2269 from drwetter/mastodon-3.0
Hint for mastodon
2022-11-10 16:33:10 +01:00
Dirk WetterandGitHub 1172327509 Hint for mastodon
... ... and to a separate account
2022-11-10 15:14:21 +01:00
Dirk WetterandGitHub 87bae00fa5 Merge pull request #2267 from drwetter/workflow_update_3.0
Restrict permissions, update actions
2022-11-10 10:55:39 +01:00
Dirk WetterandGitHub 9eeb93625d Merge pull request #2263 from dcooper16/run_pfs_infinite_loop
Fix infinite loop in run_pfs()
2022-11-10 10:49:33 +01:00
Dirk Wetter b8afca6be1 Restrict permissions, update actions
The actions release numbers were taken from the 3.1dev branch.

    Note: there was one strange codespell error in PR #2263.
    Maybe the updated action will avoid this in the future.
2022-11-10 10:35:43 +01:00
Dirk WetterandGitHub abdd51d815 Merge pull request #2231 from drwetter/bump_version
Bump version
2022-09-28 09:19:37 +02:00
Dirk WetterandGitHub 3ad9c6edd0 Merge pull request #2243 from ghen2/grep-3.8
Fix grep 3.8 warnings on unneeded escapes of hyphen, slash, space.
2022-09-18 19:21:06 +02:00
Dirk WetterandGitHub 6e68763885 Merge pull request #2240 from dcooper16/neat_lis_alignment_30
Fix alignment in neat_list()
2022-09-16 09:15:17 +02:00