Commit Graph

3695 Commits

Author SHA1 Message Date
95d39fdeab Set POODLE var when exiting run_ssl_poodle()
... so that run_tls_fallback_scsv() doesn't exit with a warning.

This fixes #2708 .

This is for 3.0 . For 3.2 see #2710
2025-03-19 23:45:28 +01:00
8e555768fb Merge pull request #2704 from dcooper16/ocsp_check_rev_ossl_ver_30
OpenSSL version check in check_revocation_ocsp()
2025-03-18 17:40:12 +01:00
c58d6cfb2a OpenSSL version check in check_revocation_ocsp()
The current code for setting $host_header in check_revocation_ocsp() will not work for LibreSSL 3.*. In addition, the code uses $OPENSSL2, which is not defined. This commit fixes these issues.
2025-03-17 11:12:55 -07:00
dd188c1daf Merge pull request #2699 from testssl/fixDockerOcspCall_3.0
Fix --phone-out + ocsp, also in docker container (3.0)
2025-03-15 21:39:24 +01:00
3485606bc0 Fix --phone-out + ocsp, also in docker container (3.0)
Previously in 4f1a91f92e there was a
double header sent to the server to check whether the certificate
was revoked.

This corrects the problem.
2025-03-15 17:20:14 +01:00
7937c0b845 Merge pull request #2696 from testssl/fix_segfault_error4-3.0
Fix segfault with error 4 in check_revocation_ocsp() when using --phone-out (3.0)
2025-03-14 19:19:16 +01:00
8d019855a3 Fix segfault with error 4 in check_revocation_ocsp() when using --phone-out (3.0)
As `--phone-out` sometimes doesn't work with our binary we switch transparently/automagically
to the vendor support openssl binary -- if available. This is the PR for 3.0, for 3.2 see #2695 .

This fixes at least #2516 where the issue has been explained/debugged in detail.
See also #2667 and #1275.
2025-03-14 17:15:40 +01:00
ab0b829d36 Merge pull request #2668 from krufab/fix/fix-typo-in-help-message
Corrected typo in help message
2025-02-23 14:29:45 +01:00
57554a9743 Corrected typo in help message
Signed-off-by: Fabio Kruger <10956489+krufab@users.noreply.github.com>
2025-02-23 00:28:15 +01:00
d2550395a7 Merge pull request #2663 from dcooper16/fix_ossl_supported_curve_check_30
Fix check for OpenSSL supported curves
2025-02-20 11:31:45 +01:00
95d7acf994 Fix check for OpenSSL supported curves
OpenSSL 3.X outputs a different error message than previous versions when $OPENSSL s_client -curves X ... is called with an unsupported curve. This was resulting in the check within find_openssl_binary() adding every curve to $OPENSSL_SUPPORTED_CURVES, even ones that were not supported. This commit changes to check in order to detect the new error message.
2025-02-19 12:49:17 -08:00
94b590f0af Merge pull request #2658 from dcooper16/fix_pattern_match_30
Fix pattern matches
2025-02-15 14:15:32 +01:00
6bc771e80d Fix pattern matches
This commit fixes three lines of code that use Bash substring matching. In each case, a list of strings to match was enclosed in brackets. This resulted in a match if the string to test contained any character from any of the strings to match. This commit fixes the issue by removing the brackets.

(The bugs were introduced in b8e9b09ca7 and 8149c2d5cf)
2025-02-13 14:33:13 -08:00
c49d9f67fa Merge pull request #2654 from testssl/drwetter-patch-1
Update workflows to Ubuntu 24.04
2025-02-12 16:22:28 +01:00
65200f4a7e Update test.yml 2025-02-12 16:21:33 +01:00
bd88c844db Update docker-3.0.yml 2025-02-12 16:21:04 +01:00
7174521b3d Update test.yml to Ububutu 22.04
Warning from Github that this will be out of service in April 1st.
2025-02-12 16:17:23 +01:00
01dd7a4bd4 Merge pull request #2651 from testssl/readme_update_3.0
Update Readme drwetter --> testssl
2025-02-07 12:29:36 +01:00
5d2d9f2c00 Merge pull request #2652 from testssl/address_addCA_issue_3.0
Address CA file parsing problem
2025-02-07 12:28:47 +01:00
b0c026ecc3 Address CA file parsing problem
.... by forbidding spaces in supplied CA files/directories

Also now we're sanitizing the cmd line parameter better `using safe_echo()`

See also #2647 .
2025-02-07 11:23:13 +01:00
305ce18931 Update Readme drwetter --> testssl
and some links in testssl.sh
2025-02-07 10:58:41 +01:00
e69a29ca0c Merge pull request #2637 from testssl/fix_2633_3.0
Fix bug when legacy NPN is tested against a TLS 1.3 host
2025-01-24 20:40:05 +01:00
7597360775 fix typo 2025-01-24 19:38:44 +01:00
f321bcf1ed Fix bug when legacy NPN is tested against a TLS 1.3 host (3.0)
When testing a TLS 1.3 host s_client_options used TLS 1.3 ciphers to test for NPN. As that is not implemented we nee dto make sure any other version is used.
This PR ensures that --after testing whether it's a TLS 1.3-only host where this test doesn't make any sense in the first place.

Fix for #2633
2025-01-24 19:38:02 +01:00
439937feb9 Merge pull request #2630 from testssl/fix_roundbracket_in_header
Fix place for round bracket for header and remove obsolete comment
2025-01-23 12:43:55 +01:00
7a6efd9483 Remove +-sign from c&p'ed diff 2025-01-23 11:32:53 +01:00
c482df82bd Fix place for round bracket and remove obsolete header
This was done in 3.2 previously, see commit 4efe324ef7 .
As everything was sanitized, the comment was removed.
2025-01-23 10:51:55 +01:00
b1f279f6af Merge pull request #2627 from dcooper16/fix_x25519_and_x448_check_30
Fix checks for whether X25519 and X448 are supported
2025-01-22 17:49:26 +01:00
2b0482359d Fix checks for whether X25519 and X448 are supported
In some cases OpenSSL returns an "unsupported" message rather than a "not found" message if X25519 and X448 are not supported. This commit changes the check for whether X5519 and X448 are supported for checking for either response.
2025-01-22 06:12:11 -08:00
b4274e8d65 Merge pull request #2603 from dcooper16/fix2599_30
Fix #2599
2024-11-27 11:36:22 +01:00
06c28bdb45 Fix #2599
This commit fixes #2599 by not wrapping fileout() messages in a "clientProblem" wrapper if TLS13_ONLY is set. The TLS13_ONLY flag being set is an indicator that fileout_banner() has already been called.
2024-11-26 10:53:54 -08:00
6570c20798 Merge pull request #2581 from drwetter/fix_2575-3.0
Fix json/csv output when STARTTLS problem is passed back (3.0)
2024-10-14 17:06:41 +02:00
c2ed4d55da Fix json/csv output when STARTTLS problem is passed back (3.0)
In rare cases testssl.sh writes to the terminal output "likely not offered" but misses the "likely" in the json/csv output.

This fixes #2575 for the 3.0 branch by adding that word and amending the return value 4 with a comment.
2024-10-14 16:26:23 +02:00
d248451340 Merge pull request #2578 from drwetter/fix_f5_short_rfc1918.3.0
Fix F5 cookie in 10.x.x.x.  (3.0)
2024-10-13 10:50:19 +02:00
968e5509ad Fix F5 cookie in 10.x.x.x. (3.0)
The F5 cookie decoder doesn't detect IPs in the 10.x.x.x space for non-encrypted cookies. This fixes the regex pattern, see also
https://github.com/drwetter/F5-BIGIP-Decoder/pull/4 and https://github.com/drwetter/testssl.sh/pull/2577
2024-10-12 21:06:21 +02:00
eee26817c5 Merge pull request #2560 from drwetter/fix_docker_3.0
Fix the Dockerfile (3.0) env (hopefully)
2024-09-05 17:59:26 +02:00
73fa5607d8 restrict CI run to pull 2024-09-05 17:55:44 +02:00
cebb52f698 Fix the Dockerfile env (hopefully)
* Upgrade both GHCR and Docker hub foile to alpine 3.2
* uses openssl version 3.3 as a alternative to option (default is still "ours"
* docker 3.0 yml hast now ubuntu-22.04 (not EOL) + "latest" omitted
2024-09-05 17:44:33 +02:00
1296279fa9 Merge pull request #2554 from drwetter/noCtrlCharInHeader_3.0
No ctrl char in header (3.0)
2024-09-03 20:50:00 +02:00
27f996d99f Remove crtl chars from HTTP header (3.0)
... which fixes #2337
2024-09-03 19:33:09 +02:00
6ce7b643ed Merge pull request #2550 from drwetter/banner_3.0
Improve banner (3.0)
2024-09-03 19:13:36 +02:00
196cd53dd5 Fix CI 2024-09-03 18:25:32 +02:00
ac81c182b1 Fix CI 2024-09-03 18:24:51 +02:00
52374e552e handle spell errors 2024-09-03 15:27:42 +02:00
44a60ff80b Improve banner (3.0)
... for readablity and bugs to be filed (see #2506)

This PR defines a short string for the OpenSSL banner as some suppliers have
makde them (unnecessarily) long so that it won't fit in the banner.

The banner also now omits the built line nad bash version when scanning
as for the user it is normally not important.
2024-09-03 15:17:23 +02:00
6d714d6b99 Merge pull request #2546 from drwetter/fix_2542_3.0
fix typo
2024-08-26 10:44:30 +02:00
69d3cff51c fix typo 2024-08-26 10:42:34 +02:00
7db944e584 Merge pull request #2536 from drwetter/update_CAstores-3.0
Update Truststores (3.0)
2024-07-24 09:28:39 +02:00
887f21609a Update Truststores (3.0)
Same as #2528, only for the 3.0 branch.

- Mozilla: 2024-7-02
- Debian 12, ca-certificates from 20230311
- JDK 21.04
- Apple via https://github.com/apple-oss-distributions/security_certificates (according to git log latest change Fri Dec 15 00:44:35 2023)
- Microsoft via CertUtil (date of this PR)

Modified Readme to reflect that the Apple CA certificates are better to retrieve from GH and clarified minor things.

This also fixes #2525 (for 3.0), where >=2 certificates were missing.
2024-07-23 12:20:09 +02:00
08a430e01a Merge pull request #2531 from drwetter/fix_ipv6_ula_and_more-3.0
Fix IPv6 addresses (3.0)
2024-07-22 23:31:55 +02:00