Git
/
cheat
mirror of https://github.com/cheat/cheat.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

perf(Sheets): do not walk hidden directories 

Modify `Sheets.Load` to not walk hidden directories like `.git`. This
optimization can potentially prevent thousands of system calls from
being made, because `.git` directories can contain many files.
This commit is contained in:
Chris Allen Lane 2022-08-04 19:26:07 -04:00 committed by Chris Lane
parent cfd1702bc6
commit 484b447391
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
internal/sheets/load.go
View File

@ -2,6 +2,7 @@ package sheets
import (
"fmt"
"io/fs"
"os"
"path/filepath"
"strings"
@ -55,7 +56,11 @@ func Load(cheatpaths []cp.Cheatpath) ([]map[string]sheet.Sheet, error) {
// contained within hidden directories in the middle of a path, though
// that should not realistically occur.
if strings.HasPrefix(title, ".") || strings.HasPrefix(info.Name(), ".") {
return nil
// Do not walk hidden directories. This is important,
// because it's common for cheatsheets to be stored in
// version-control, and a `.git` directory can easily
// contain thousands of files.
return fs.SkipDir
}
// parse the cheatsheet file into a `sheet` struct