mirror of
https://github.com/cheat/cheat.git
synced 2026-03-07 03:03:32 +01:00
cc85a4bdb1
Bug fixes: - Fix inverted pager detection logic (returned error instead of path) - Fix repo.Clone ignoring destination directory parameter - Fix sheet loading using append on pre-sized slices - Clean up partial files on copy failure - Trim whitespace from editor config Security: - Add path traversal protection for cheatsheet names Performance: - Move regex compilation outside search loop - Replace string concatenation with strings.Join in search Build: - Remove go:generate; embed config and usage as string literals - Parallelize release builds - Add fuzz testing infrastructure Testing: - Improve test coverage from 38.9% to 50.2% - Add fuzz tests for search, filter, tags, and validation Documentation: - Fix inaccurate code examples in HACKING.md - Add missing --conf and --all options to man page - Add ADRs for path traversal, env parsing, and search parallelization - Update CONTRIBUTING.md to reflect project policy Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
96 lines
2.2 KiB
Go
96 lines
2.2 KiB
Go
package config
|
|
|
|
import (
|
|
"os"
|
|
"runtime"
|
|
"testing"
|
|
)
|
|
|
|
// TestEditor tests the Editor function
|
|
func TestEditor(t *testing.T) {
|
|
// Save original env vars
|
|
oldVisual := os.Getenv("VISUAL")
|
|
oldEditor := os.Getenv("EDITOR")
|
|
defer func() {
|
|
os.Setenv("VISUAL", oldVisual)
|
|
os.Setenv("EDITOR", oldEditor)
|
|
}()
|
|
|
|
t.Run("windows default", func(t *testing.T) {
|
|
if runtime.GOOS != "windows" {
|
|
t.Skip("skipping windows test on non-windows platform")
|
|
}
|
|
|
|
// Clear env vars
|
|
os.Setenv("VISUAL", "")
|
|
os.Setenv("EDITOR", "")
|
|
|
|
editor, err := Editor()
|
|
if err != nil {
|
|
t.Errorf("unexpected error: %v", err)
|
|
}
|
|
if editor != "notepad" {
|
|
t.Errorf("expected 'notepad' on windows, got %s", editor)
|
|
}
|
|
})
|
|
|
|
t.Run("VISUAL takes precedence", func(t *testing.T) {
|
|
if runtime.GOOS == "windows" {
|
|
t.Skip("skipping non-windows test on windows platform")
|
|
}
|
|
|
|
os.Setenv("VISUAL", "emacs")
|
|
os.Setenv("EDITOR", "nano")
|
|
|
|
editor, err := Editor()
|
|
if err != nil {
|
|
t.Errorf("unexpected error: %v", err)
|
|
}
|
|
if editor != "emacs" {
|
|
t.Errorf("expected VISUAL to take precedence, got %s", editor)
|
|
}
|
|
})
|
|
|
|
t.Run("EDITOR when no VISUAL", func(t *testing.T) {
|
|
if runtime.GOOS == "windows" {
|
|
t.Skip("skipping non-windows test on windows platform")
|
|
}
|
|
|
|
os.Setenv("VISUAL", "")
|
|
os.Setenv("EDITOR", "vim")
|
|
|
|
editor, err := Editor()
|
|
if err != nil {
|
|
t.Errorf("unexpected error: %v", err)
|
|
}
|
|
if editor != "vim" {
|
|
t.Errorf("expected EDITOR value, got %s", editor)
|
|
}
|
|
})
|
|
|
|
t.Run("no editor found error", func(t *testing.T) {
|
|
if runtime.GOOS == "windows" {
|
|
t.Skip("skipping non-windows test on windows platform")
|
|
}
|
|
|
|
// Clear all environment variables
|
|
os.Setenv("VISUAL", "")
|
|
os.Setenv("EDITOR", "")
|
|
|
|
// Create a custom PATH that doesn't include common editors
|
|
oldPath := os.Getenv("PATH")
|
|
defer os.Setenv("PATH", oldPath)
|
|
|
|
// Set a very limited PATH that won't have editors
|
|
os.Setenv("PATH", "/nonexistent")
|
|
|
|
editor, err := Editor()
|
|
|
|
// If we found an editor, it's likely in the system
|
|
// This test might not always produce an error on systems with editors
|
|
if editor == "" && err == nil {
|
|
t.Error("expected error when no editor found")
|
|
}
|
|
})
|
|
}
|