mirror of
https://github.com/cheat/cheat.git
synced 2026-03-07 11:13:33 +01:00
- Remove unused parameters, dead files, and inaccurate doc.go files - Extract shared helpers, eliminate duplication - Rename cheatpath.Cheatpath to cheatpath.Path - Optimize filesystem walks (WalkDir, skip .git) - Move sheet name validation to sheet.Validate - Move integration tests to test/integration/ - Consolidate internal/mock into mocks/ - Move fuzz.sh to test/ - Inline loadSheets helper into command callers - Extract config.New into its own file - Fix stale references in HACKING.md and CLAUDE.md - Restore plan9 build target - Remove redundant and low-value tests - Clean up project documentation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
41 lines
1.0 KiB
Go
41 lines
1.0 KiB
Go
package sheet
|
|
|
|
import (
|
|
"fmt"
|
|
"path/filepath"
|
|
"strings"
|
|
)
|
|
|
|
// Validate ensures that a cheatsheet name does not contain
|
|
// directory traversal sequences or other potentially dangerous patterns.
|
|
func Validate(name string) error {
|
|
// Reject empty names
|
|
if name == "" {
|
|
return fmt.Errorf("cheatsheet name cannot be empty")
|
|
}
|
|
|
|
// Reject names containing directory traversal
|
|
if strings.Contains(name, "..") {
|
|
return fmt.Errorf("cheatsheet name cannot contain '..'")
|
|
}
|
|
|
|
// Reject absolute paths
|
|
if filepath.IsAbs(name) {
|
|
return fmt.Errorf("cheatsheet name cannot be an absolute path")
|
|
}
|
|
|
|
// Reject names that start with ~ (home directory expansion)
|
|
if strings.HasPrefix(name, "~") {
|
|
return fmt.Errorf("cheatsheet name cannot start with '~'")
|
|
}
|
|
|
|
// Reject hidden files (files that start with a dot)
|
|
// We don't display hidden files, so we shouldn't create them
|
|
filename := filepath.Base(name)
|
|
if strings.HasPrefix(filename, ".") {
|
|
return fmt.Errorf("cheatsheet name cannot start with '.' (hidden files are not supported)")
|
|
}
|
|
|
|
return nil
|
|
}
|