Dirk Wetter
d6a9360f2c
Fix known DH but not weak keys to be capped @ A not B
2020-04-22 14:08:58 +02:00
Dirk Wetter
7da2e90083
Honor Magnus
2020-04-20 22:49:48 +02:00
Dirk Wetter
577370a272
Add rating
2020-04-20 22:49:31 +02:00
Dirk Wetter
b1ef3a020f
add single blank for pretty JSON
2020-04-20 22:48:31 +02:00
Dirk Wetter
e9e11e213a
* Grading --> Rating. But we still hand out grades
2020-04-20 22:45:58 +02:00
Dirk Wetter
c3f09f56f7
Grading --> Rating
...
but we still hand out grades
2020-04-20 22:41:14 +02:00
Dirk Wetter
127cf95e22
Address rating for STARTTLS tests
...
STARTTLS tests should always give a bad rating because of the missing
trust 1) . That's why we don't provide more details as "T". Maybe we
decide later to provide an environment variable which still
shows this warning but divulges more details. TBC.
Documentation is missing for STARTTLS + grades.
1) There might be cases also for STARTTLS where encryption is enforced
and e.g. the certificate fingerprint is validated. As this is highly
protcol specific we won't test that.
2020-04-20 12:26:33 +02:00
Dirk Wetter and GitHub
fe5e10ff9d
Merge pull request #1574 from magnuslarsen/grading_dev
...
Less aggresive TLS_FALLBACK_SCVS checks
2020-04-20 11:45:56 +02:00
Dirk
4960829433
Fix JSON for grading / rating
2020-04-19 23:54:42 +02:00
Dirk Wetter
d9f2ca80d6
fix conditional statement (regression)
2020-04-17 14:54:11 +02:00
Dirk Wetter
2c10676e03
Output polish, minor code polish to grading
...
... and squash the TLS 1.2 grading cap for TLS 1.3 only server
2020-04-17 14:49:35 +02:00
Dirk Wetter
359965dc17
First round of polishing @magnuslarsen's contribution
...
* instead of DISABLE_GRADING we use do_grading as for run_* functions we currently don't
support global variables
* Add AEAD cipher set_grade_cap (needs to be tested though)
* remove redundant quotes
* be to be safe add double quotes at other places
* Fix typos
* Polishing output
Tasks (not complete):
* Review whether it is rated as intended
* Do we want to mofify SSL Lab's rating? (SSLv3 e.g., T for SHA1 certificate?)
* Does JSON output work?
* TLS 1.3 only server are not rated properly --> wait for SSLlabs?
* SWEET32: rating refers to TLS 1.1 atm. SSLlabs docu doesn't give a hint
(is their docu incomplete?)
* Rating for STARTTLS at all?
2020-04-17 13:24:32 +02:00
Dirk Wetter
64735d0241
Remove env variable DISABLE_GRADING
...
as for run_* functions we currntly don't have that.
Also AEAD as WIP we can remove that from the doc
2020-04-17 13:22:30 +02:00
Dirk Wetter
9de5421e5c
Merge branch 'grading_dev' of git://github.com/magnuslarsen/testssl.sh into magnuslarsen-grading_dev
2020-04-17 10:52:44 +02:00
Dirk Wetter and GitHub
e0d7945c8a
Merge pull request #1570 from petecooper/3.1dev
...
README version bump for .zip download
2020-04-15 17:16:06 +02:00
Dirk Wetter and GitHub
8ce781c71d
Merge pull request #1567 from drwetter/renamed_to_fs
...
Rename PFS/perfect forward secrecy - -> FS/forward secrecy
2020-04-14 20:21:52 +02:00
Dirk Wetter and GitHub
150fd156bb
Merge pull request #1565 from drwetter/cvs_remove
...
Polishing
2020-04-14 16:41:50 +02:00
Dirk Wetter
8c466bf2ee
Rename PFS/perfect forward secrecy to FS/forward secrecy
...
In all instances:
* command line (will break things)
* JSON IDs (will break things)
* in the documentation
* in the travis checks where used
* everywhere in the code: variables, functions, comments
2020-04-14 15:53:05 +02:00
Dirk
67cfe013b1
Polishing
...
* remove CVS variables
* add 2x https links instead of http in code doc
2020-04-14 13:35:26 +02:00
Dirk Wetter and GitHub
663d592466
Merge pull request #1526 from dcooper16/fix1514
...
Fix #1514
2020-04-14 12:52:38 +02:00
Dirk
e345abb023
Merge branch 'multiflexi-3.1dev' into 3.1dev
2020-04-13 23:01:15 +02:00
Dirk
ae7b74cf73
Tuning multiflexi's fixes
2020-04-13 22:59:13 +02:00
Dirk Wetter and GitHub
9d2901edd0
Merge pull request #1471 from drwetter/docu_update
...
Documention update
2020-04-09 19:57:10 +02:00
Dirk Wetter and GitHub
dbff4a3706
Merge pull request #1554 from dcooper16/align_run_cipherlists
...
Align run_cipherlists() with pr_cipher_quality()
2020-04-02 13:53:54 +02:00
Dirk Wetter and GitHub
f16c7af687
Merge pull request #1553 from dcooper16/pr_cipher_quality_gost
...
Handle GOST ciphers in pr_cipher_quality()
2020-04-02 13:53:28 +02:00
Dirk Wetter and GitHub
d5d702104f
Merge pull request #1556 from dcooper16/fix1551
...
Fix #1551
2020-04-01 22:28:25 +02:00
Dirk Wetter and GitHub
061732a5fb
Merge pull request #1552 from drwetter/drwetter-patch-1
...
Badges from shields.io / Monitoring Links
2020-04-01 12:41:16 +02:00
Dirk Wetter and GitHub
333ccdfb41
Badges from shields.io / Monitoring Links
2020-04-01 12:40:56 +02:00
Dirk Wetter and GitHub
d32743b2eb
Merge pull request #1548 from dcooper16/adjust_pr_cipher_quality
...
Adjust pr_cipher_quality ratings
2020-03-31 14:09:47 +02:00
Dirk Wetter and GitHub
8ff45208c3
Merge pull request #1546 from dcooper16/display_ciphernames_bug
...
Fix bug in setting DISPLAY_CIPHERNAMES
2020-03-25 18:28:03 +01:00
Dirk Wetter and GitHub
1e94d5a2f6
Merge pull request #1544 from mkauschi/replace-printf-with-tm_out
...
Replace printf with tm_out
2020-03-24 10:56:10 +01:00
Dirk Wetter and GitHub
3a003d9ab9
Merge pull request #1538 from mkauschi/fix_bug_with_basicauth_generation
...
Fix basicauth bug where a newline is added to the user:password string before encoding
2020-03-18 14:51:18 +01:00
Dirk Wetter and GitHub
32df6b8bef
Merge pull request #1533 from drwetter/breach_output31
...
Fix output for BEAST when no SSL3 or TLS
2020-03-07 12:16:11 +01:00
Dirk
8242607d94
Fix output for BEAST when no SSL3 or TLS
...
LF added
2020-03-06 22:06:13 +01:00
Dirk Wetter and GitHub
9cd4cf3eb9
Merge pull request #1531 from dcooper16/fix_typo_emphasize_stuff_in_headers
...
Fix typo in emphasize_stuff_in_headers()
2020-03-06 21:28:28 +01:00
Dirk Wetter and GitHub
5aadc1951d
Merge pull request #1523 from drwetter/pwdfix3.1
...
Avoid external "/bin/pwd"
2020-03-06 14:59:15 +01:00
Dirk Wetter and GitHub
6f02101ae0
Merge pull request #1499 from dcooper16/fix_printing_percent
...
Fix printing percent characters
2020-03-06 14:35:31 +01:00
Dirk Wetter and GitHub
466f08c846
Merge pull request #1481 from dcooper16/fix_html
...
Fix HTML generation
2020-03-06 13:40:41 +01:00
Dirk Wetter
0469d6a2b1
Avoid external "/bin/pwd"
...
.. as it may not be available everywhere, see #1521 (NixOS).
This commit replaces all instances from pwd or /bin/pwd by $PWD.
It is a bash internal and the fastest. Also it added some quotes
to PWD a it may contain white spaces in the future (currently
there's a check for it that it won't)
2020-03-06 13:24:56 +01:00
Dirk Wetter and GitHub
b8d1a3506a
Merge pull request #1525 from drwetter/update_template
...
Update ISSUE_TEMPLATE.md
2020-03-06 13:01:03 +01:00
Dirk Wetter and GitHub
9f1fa04e07
Update ISSUE_TEMPLATE.md
2020-03-03 21:18:09 +01:00
Dirk Wetter
1fb96df369
Avoid external "/bin/pwd"
...
.. as it may not be everywhere available, see #1521 (NixOS).
This commit replaces all instances from pwd or /bin/pwd by `pwd -P`
(-P -> no symbolic link)
2020-03-03 12:36:22 +01:00
Dirk Wetter and GitHub
e0c83b2a38
add more filters
2020-02-24 14:21:28 +01:00
Dirk Wetter and GitHub
02b83cc092
Merge pull request #1516 from dcooper16/min_hsts
...
Fix use of HSTS_MIN
2020-02-21 09:59:32 +01:00
Dirk Wetter and GitHub
64fea03f66
Merge pull request #1510 from drwetter/rDNS_fixes
...
Fix for non compliant DNS PTR records
2020-02-15 15:22:22 +01:00
Dirk Wetter and GitHub
95b6189076
Merge pull request #1509 from drwetter/container1
...
remove jq and beautify last line
2020-02-15 14:08:43 +01:00
Dirk Wetter
b81c409135
Fix for non compliant DNS PTR records
...
This commit addresses two bugs: #1506 and #1508 .
First, the variable rDNS can contain multiple lines due to multiple PTR DNS
records, though this is not recommended. In those cases the multiple PTR DNS
were concatenated on the screen, without any blank.
Secondly - depending on the name server entries and on the output of the DNS
binaries used it can contain non-printable characters or characters which are
printable but later on interpreted on the output device (\032 was mentioned
in #1506 ) which on the screen was interpreted as octal 32 (decimal 26 = ▒,
try echo "\032"), so basically a terminal escape sequence was smuggled
from the DNS server to the screen of the users. In JSON pretty output we
had also this escape sequence which was fine for jsonlint but caused jq
to hiccup.
Fix: we use a loop to check for each FQDN returned. There we remove chars which
under those circumstances can show up. The blacklist is taken from RFC 1912
("Allowable characters in a label for a host name are only ASCII, letters, digits,
and the `-' character").
2020-02-15 13:43:37 +01:00
Dirk Wetter
75be8d9f38
remove jq and beautify last line
2020-02-15 12:09:33 +01:00
Dirk Wetter and GitHub
f01c1196c0
Merge pull request #1505 from dcooper16/fix_1504
...
Fix #1504
2020-02-13 17:52:06 +01:00
Dirk Wetter and GitHub
d549c833c8
Merge pull request #1501 from dcooper16/cipher_order_wide
...
Wide output for cipher order
2020-02-13 09:34:40 +01:00
Dirk Wetter and GitHub
b0cce84a7f
Merge pull request #1500 from dcooper16/shellcheck_SC2197
...
Fix Shellcheck SC2197
2020-02-10 20:45:16 +01:00
Dirk Wetter and GitHub
6da6335e5b
Merge pull request #1498 from dcooper16/minor_code_cleanup
...
Minor code cleanup
2020-02-08 10:32:46 +01:00
Dirk Wetter and GitHub
8bdad385d5
Merge pull request #1497 from dcooper16/neat_list_export
...
neat_list() and export
2020-02-07 18:14:11 +01:00
Dirk Wetter and GitHub
9a0325875e
Merge pull request #1495 from dcooper16/fix_pub_key_length_calculation
...
Fix public key length calculation
2020-02-04 21:45:52 +01:00
Dirk Wetter and GitHub
e9430bdd23
Merge pull request #1490 from drwetter/dotasurl_fix
...
Fix URL when hostname with trailing dot supplied
2020-02-04 16:20:23 +01:00
Dirk Wetter and GitHub
77398af399
Merge pull request #1492 from dcooper16/fix_typos
...
Fix typos
2020-02-04 16:18:46 +01:00
Dirk
c2df2f1fc0
Fix URL when hostname with trailing dot supplied
...
Hostnames can contain a trailing dot (and sometimes they should).
If they are supplied to testssl.sh however they will be also interpreted
as a URL PATH when the servive is HTTP.
This commit fixes that.
2020-02-03 22:26:01 +01:00
Dirk Wetter and GitHub
ccafd9125b
Merge pull request #1488 from dcooper16/fix_client_simulation
...
Fix client simulation
2020-01-31 20:23:58 +01:00
Dirk Wetter and GitHub
7c85b44a9f
Merge pull request #1482 from dcooper16/shellcheck_SC2178
...
Suppress shellcheck issue SC2178
2020-01-31 09:23:06 +01:00
Dirk Wetter and GitHub
e8b7a04e53
Merge pull request #1487 from simondeziel/dup-cipher
...
Remove (harmless) AESGCM dup in the strong ciphers list
2020-01-31 09:22:03 +01:00
Dirk Wetter and GitHub
2f54613d6d
Merge pull request #1484 from dcooper16/tls13_post_handshake
...
TLS 1.3 post-handshake messages
2020-01-31 08:55:08 +01:00
Dirk Wetter and GitHub
7443a532cf
Merge pull request #1486 from drwetter/fix_ids_friendly
...
Fix --ids-friendly
2020-01-31 08:48:01 +01:00
Dirk Wetter and GitHub
89fd902b18
Merge pull request #1483 from dcooper16/minor_code_cleanup
...
Minor code cleanup
2020-01-31 08:41:43 +01:00
Dirk Wetter
c4920f61e4
rename query_globals() --> count_do_variables()
...
.. and fix one problem instroduced with last patch (testssl.sh
din't work correclty if only an URI was supplied)
2020-01-30 22:25:10 +01:00
Dirk Wetter
073d383f76
Fix switch --ids-friendly
...
This switch had no effect. There was probably a regression
problem as it worked before.
Besides fixing that the large case statement in parse_cmd_line()
was simplified, in a sense that banner and help functions were
moved to a separate case statement.
2020-01-30 21:49:56 +01:00
Dirk Wetter and GitHub
3a73a97b67
Merge pull request #1480 from drwetter/readme-patch1
...
Status update / mir rephrasing of key features
2020-01-30 18:14:43 +01:00
Dirk Wetter and GitHub
16907cf77e
Status update / mir rephrasing of key features
2020-01-30 18:14:20 +01:00
Dirk Wetter and GitHub
ef21f3f9bf
Merge pull request #1476 from dcooper16/tls13_finished_messages
...
TLS 1.3 Finished messages
2020-01-30 10:26:27 +01:00
Dirk Wetter and GitHub
5e9767a17c
Merge pull request #1477 from dcooper16/faster_gcm
...
Speedup AES-GCM
2020-01-30 10:22:02 +01:00
Dirk Wetter and GitHub
3da67437f3
Merge pull request #1475 from dcooper16/reorganize_key_derivation
...
Reorganize TLS 1.3 key derivation
2020-01-27 21:52:24 +01:00
Dirk Wetter and GitHub
c3bab98b92
Merge pull request #1474 from drwetter/backport_4b573dd
...
Suppress displaying an error in maketempf()
2020-01-26 01:30:58 +01:00
Dirk
c63547ca7b
Suppress displaying an error in maketempf()
2020-01-26 01:29:18 +01:00
Dirk
4b573dd833
Suppress displaying an error in maketempf()
2020-01-26 01:24:11 +01:00
Dirk Wetter and GitHub
51ca429b48
Merge pull request #1473 from dcooper16/aead
...
Full AEAD cipher implementations
2020-01-25 12:37:28 +01:00
Dirk Wetter
3cdb16a969
Prepare baseline_ipv4_http as a good example ...
...
... as indicated in CONTRIBUTING.md / Coding_Convention.md
2020-01-24 17:42:17 +01:00
Dirk Wetter and GitHub
1ad7a65adf
Merge pull request #1472 from drwetter/reorder
...
Reorder functions and some variables
2020-01-24 14:46:18 +01:00
Dirk Wetter
7d3ff19442
Notes wrt [[, references to bash hackers wiki
2020-01-24 14:24:22 +01:00
Dirk Wetter
d44a643fab
Reorder functions and some variables
...
For a fresh start it seemed a good idea to cleanup
the order of functions and some variables so that
those with the same functionality are somewhat grouped.
Some of the functions have now a header and a foooter
to make it easier to spot and use then. Also for added future
functions the hope is that they will be put where they better
fit
2020-01-24 13:58:05 +01:00
Dirk Wetter
6c892afecd
Move from wiki hereto plus sorting+rephrasing
2020-01-24 13:09:05 +01:00
Dirk Wetter
385485d39b
More friendly phrased. Incl. soon to follow coding convention
2020-01-24 11:33:11 +01:00
Dirk
67598e824f
Start next release
2020-01-23 22:24:33 +01:00
Dirk Wetter and GitHub
b0b084dcda
Merge pull request #1442 from drwetter/bump_version
...
bump version to final
2020-01-23 18:08:23 +01:00
Dirk Wetter and GitHub
a11a060acb
Merge pull request #1456 from drwetter/changes_etc
...
Update attributions and changes for release
2020-01-23 18:05:50 +01:00
Dirk Wetter and GitHub
a9e5bcc30c
Merge pull request #1470 from drwetter/1xmsg_squash
...
Squash the last futile -msg for $OPENSSL
2020-01-23 11:03:46 +01:00
Dirk
ace4098693
Squash the last futile -msg for $OPENSSL
...
... see also https://github.com/drwetter/testssl.sh/pull/1468#discussion_r369786007
2020-01-23 09:46:33 +01:00
Dirk Wetter and GitHub
631755ceb1
Merge pull request #1464 from drwetter/further_handshakes
...
Further handshakes / minor changes
2020-01-22 22:30:16 +01:00
Dirk Wetter and GitHub
fa4f1e4366
Merge pull request #1468 from nosnilmot/fix-xmpp-starttls
...
Fix XMPP starttls
2020-01-22 21:09:51 +01:00
Dirk
5083e950d2
Move debugging remainders detection to t/00_testssl_help.t
2020-01-22 21:04:23 +01:00
Dirk Wetter and GitHub
ec722e0e9c
Merge pull request #1469 from dcooper16/simplify_draft_tls13_version_determination
...
Simplify code to determine draft TLS 1.3 version
2020-01-22 20:39:10 +01:00
Dirk Wetter and GitHub
f7ab5a0821
Move quotes...
...
as David suggested.
2020-01-22 20:34:00 +01:00
Dirk Wetter and GitHub
7619e430f2
Merge pull request #1466 from dcooper16/fix_run_ssl_poodle
...
Fix run_ssl_poodle()
2020-01-22 18:05:08 +01:00
Dirk Wetter and GitHub
2602e14191
Merge pull request #1465 from dcooper16/undo_copy_paste_error
...
Undo copy and paste error
2020-01-22 17:25:33 +01:00
Dirk Wetter and GitHub
2181061c6e
Merge pull request #1463 from drwetter/shortcurt_vulns
...
Shortcuts for vulnerability tests for TLS 1.3 only servers
2020-01-22 15:37:11 +01:00
Dirk Wetter
eeb1acd749
Android 9 still has 2 signature hash algos: x0201 + x0203
2020-01-22 11:41:42 +01:00
Dirk
d4d5a61a0b
Hopefully make Travis shut up now
...
picked a TLS 1.2 host
2020-01-22 11:30:21 +01:00
Dirk
cae052cfab
Address some HTML check failures in travis
...
(shouldn't work too late)
2020-01-22 11:29:04 +01:00
Dirk Wetter
7c66ed47c0
All self retrieved Android handshakes modified to service ANY
2020-01-22 10:58:00 +01:00
Dirk Wetter
a50a660d6c
Add Android 10 client simulation
2020-01-22 10:54:50 +01:00
Dirk Wetter
ca8054184b
remove also leading colon in helper script bc of GREASE
2020-01-22 10:52:07 +01:00
Dirk
39abb27dd9
cloudflare seems not good for html travis checks
2020-01-22 00:28:59 +01:00