mirror of
https://github.com/cheat/cheat.git
synced 2026-03-07 11:13:33 +01:00
cc85a4bdb1
Bug fixes: - Fix inverted pager detection logic (returned error instead of path) - Fix repo.Clone ignoring destination directory parameter - Fix sheet loading using append on pre-sized slices - Clean up partial files on copy failure - Trim whitespace from editor config Security: - Add path traversal protection for cheatsheet names Performance: - Move regex compilation outside search loop - Replace string concatenation with strings.Join in search Build: - Remove go:generate; embed config and usage as string literals - Parallelize release builds - Add fuzz testing infrastructure Testing: - Improve test coverage from 38.9% to 50.2% - Add fuzz tests for search, filter, tags, and validation Documentation: - Fix inaccurate code examples in HACKING.md - Add missing --conf and --all options to man page - Add ADRs for path traversal, env parsing, and search parallelization - Update CONTRIBUTING.md to reflect project policy Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
50 lines
1.3 KiB
Go
50 lines
1.3 KiB
Go
package repo
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
)
|
|
|
|
// TestClone tests the Clone function
|
|
func TestClone(t *testing.T) {
|
|
// This test requires network access, so we'll only test error cases
|
|
// that don't require actual cloning
|
|
|
|
t.Run("clone to read-only directory", func(t *testing.T) {
|
|
if os.Getuid() == 0 {
|
|
t.Skip("Cannot test read-only directory as root")
|
|
}
|
|
|
|
// Create a temporary directory
|
|
tempDir, err := os.MkdirTemp("", "cheat-clone-test-*")
|
|
if err != nil {
|
|
t.Fatalf("failed to create temp dir: %v", err)
|
|
}
|
|
defer os.RemoveAll(tempDir)
|
|
|
|
// Create a read-only subdirectory
|
|
readOnlyDir := filepath.Join(tempDir, "readonly")
|
|
if err := os.Mkdir(readOnlyDir, 0555); err != nil {
|
|
t.Fatalf("failed to create read-only dir: %v", err)
|
|
}
|
|
|
|
// Attempt to clone to read-only directory
|
|
targetDir := filepath.Join(readOnlyDir, "cheatsheets")
|
|
err = Clone(targetDir)
|
|
|
|
// Should fail because we can't write to read-only directory
|
|
if err == nil {
|
|
t.Error("expected error when cloning to read-only directory, got nil")
|
|
}
|
|
})
|
|
|
|
t.Run("clone to invalid path", func(t *testing.T) {
|
|
// Try to clone to a path with null bytes (invalid on most filesystems)
|
|
err := Clone("/tmp/invalid\x00path")
|
|
if err == nil {
|
|
t.Error("expected error with invalid path, got nil")
|
|
}
|
|
})
|
|
}
|